search

libretro / beetle-pce-fast-libretro

Standalone fork of Mednafen PCE Fast to libretro
GNU General Public License v2.0
29 stars 55 forks source link

WinRT build, bugfix #63

Closed albertofustinoni closed 7 years ago

albertofustinoni commented 7 years ago

Some changes to build and run in WinRT, fixed a bug (geometry info updated with max width/height unset)

@twinaphex I have a few PRs open for Beetle cores, with essentially the same changes. If there's something you would like me to change, just tell me :) Thank you in advance.

inactive123 commented 7 years ago

Hi there,

what makes me wary a bit about these PRs is how tchar.h is stubbed out. Wouldn't that cause issues with earlier MSVC versions? Maybe you can put an ifdef around this? We'd like to preserve backwards compatibility with the older MSVC versions while also at the same time being able to target MSVC 2017/WinRT.

And in case you address the tchar.h issue, you might want to address it in some of the other PRs for some of the other Beetle cores as well.

albertofustinoni commented 7 years ago

I see your point.

I'll wrap those lines in ifdefs as you suggest.

Thank you

albertofustinoni commented 7 years ago

@twinaphex Changed the files to do conditional compilation instead of excluding tchar.h