Video Output bug outside screen

libretro / beetle-pce-libretro

Standalone hard fork of Mednafen PCE to libretro

GNU General Public License v2.0

25 stars 26 forks source link

Video Output bug outside screen #62

Open soundsnow opened 1 year ago

soundsnow commented 1 year ago

pce fast and supergrafx cores are ok only @LibretroAdmin updated this pce core with this bug screenshot tool: RetroArch 1941 - Counter Attack (Japan)-230415-095610

ghost commented 1 year ago

Are you using a handheld device like PSP?

That looks a non-power-of-2 pitch bug with the physical hardware.

pce_fast = 512 width
pce_full = 1365 width (triggering the skew).

We'd have to round up to 2048, but also need someone for testing.

ghost commented 1 year ago

I remember now. Some hardware are optimized (fixed) for 4-byte framebuffer alignment.

Likely why there's the +3 in the code, but it's not fully done.

EDIT: Reference: https://github.com/libretro/beetle-pce-libretro/issues/3

https://github.com/libretro/beetle-pce-libretro/commit/289a25b6fdff1afe4247dd802562a673d7ab68f9 (that's not enough though)

ghost commented 1 year ago

Tagging #69