search

libretro / beetle-psx-libretro

Standalone port/fork of Mednafen PSX to the Libretro API.
GNU General Public License v2.0
310 stars 130 forks source link

Vulkan Renderer Graphical Bug Compilation Thread #129

Open saftle opened 7 years ago

saftle commented 7 years ago

This thread is a compiled list of all bugs that are currently visible when using the vulkan renderer thread in comparison with the software renderer.

As a starting point, every bug should be validated first with the default options, in order to isolate whether the vulkan renderer being enabled by itself causes the issue, or if it's due to one of the additional options.

If you encounter a bug please make a screenshot of the occurence in Vulkan and a comparison screenshot in Software with the following options set:

If a bug occurs with one of the additional options (non PGXP related), please make a third screenshot showcasing the bug with that option set (3x Screenshots: Vulkan, Software, Additional Option) with a description of the option that is enabled.

Please link all images to Imgur (or another image hoster), in order to minimize page load. Also, when your reported bug has been fixed, please test it against the game that you used as an example, and edit your post to say that the problem has been fixed. Thank you!

Also don't forget to mention which graphics card you are using, what driver version you have installed, your operating system ,and the GIT version of the corewith which you reproduced the bug on (can be seen when loading a core in the lower left hand corner).

Please use the next bug report as an example.

saftle commented 7 years ago

Breath of Fire III FIXED with ce412d5!

Region/Version: USA

Core Options: All Options as shown above Core Version: 474e7ab Graphics Card: GTX 970 Driver Version: 376.19 OS: Windows 10 x64 Anniversary Update

Bug Description: 2D is off by one pixel resulting in garbled vertical line next to sprites. This affects the sprites when moving primarily. Switch between screenshots to see how the entire screen shifts one pixel to the left. This issue affects the GL renderer as well.

Vulkan Screenshot: http://i.imgur.com/6TauFym.png

Software Screenshot: http://i.imgur.com/wqTGRFo.png

saftle commented 7 years ago

007 - The World Is Not Enough

Region/Version: USA

Core Options: All Options as shown above Core Version: ce412d5 Graphics Card: GTX 970 Driver Version: 376.19 OS: Windows 10 x64 Anniversary Update

Bug Description I: Opening - Garbled Textures When EA logo fades away. Same issue affects the GL Renderer: https://github.com/libretro/beetle-psx-libretro/issues/43#issuecomment-223126739. Same issue affects 007 - Tomorrow Never Dies (USA)

Vulkan Screenshot: GL Issue Screenshot used: https://cloud.githubusercontent.com/assets/852777/15725546/c45c8f34-284c-11e6-9e4b-a4e0fa3b48cb.png

Software Screenshot: No screenshot possible. Fades to next screen without garbled graphics.

Bug Description II: Opening - Green flash before MGM Interactive video starts. Same issue affects the GL Renderer: https://github.com/libretro/beetle-psx-libretro/issues/43#issuecomment-223126739. Same issue affects 007 - Tomorrow Never Dies (USA)

Vulkan Screenshot: GL Issue Screenshot used: https://cloud.githubusercontent.com/assets/852777/15725851/14054098-284e-11e6-9649-c52f07469fa7.png

Software Screenshot: No screenshot possible. Fades to black without garbled green screen

saftle commented 7 years ago

007 Racing

Region/Version: USA

Core Options: All Options as shown above Core Version: ce412d5 Graphics Card: GTX 970 Driver Version: 376.19 OS: Windows 10 x64 Anniversary Update

Bug Description: Initial loading screen before main menu is cut off. Same issue affects the GL Renderer: https://github.com/libretro/beetle-psx-libretro/issues/43#issuecomment-223764216.

Vulkan Screenshot: GL Issue Screenshot used: https://cloud.githubusercontent.com/assets/852777/15800682/7999a4ba-2a80-11e6-9ffe-23fc481eb912.png

Software Screenshot: GL Issue Screenshot used: https://cloud.githubusercontent.com/assets/852777/15800687/846ba8b6-2a80-11e6-808d-13a5fe943e3a.png

Aerocatia commented 7 years ago

CTR: Crash Team Racing

Region/Version: USA OS: Windows 7 Video Card: Nvidia GeForce GTX 1080 Driver: 376.19

Core Version: ce412d5 Core Options: All Options as shown above

Bug Description: These screenshots show two bugs. First there are graphical errors on the load/save screen and also the game is meant to be letterboxed. the lack of letterboxing causes the entire game to be rendered at the incorrect aspect ratio.

Vulkan Screenshot: https://s15.postimg.org/n4xtasxm3/CTR_Crash_Team_Racing_USA_PSN_161206_22021.png Software Screenshot: https://s15.postimg.org/q17fl2lkr/CTR_Crash_Team_Racing_USA_PSN_161206_22135.png

Bug Description 2: In this screenshot there is a graphical error on a intro screen when the game starts.

Vulkan Screenshot: https://s15.postimg.org/fmgdg4n6z/CTR_Crash_Team_Racing_USA_PSN_161206_22351.png Software Screenshot: https://s11.postimg.org/8tp5nrobn/CTR_Crash_Team_Racing_USA_PSN_161206_22371.png

There also is no dithering under vulkan even though it is enabled in core options.

rz5 commented 7 years ago

Can confirm that the Vulkan renderer does not respect color depth or dithering core options. It will render at 32bpp color depth and disable the PSX dither pattern.

ilag11111 commented 7 years ago

Gran Turismo 2

Region/Version: U 1.2

Core Version: ce412d5 Core Options: All as per first post Graphics Card: GTX 680 Driver Version: 375.20 OS: Ubuntu 16.04 64-bit

Flickering during races

Description: In races, elements will flicker, including the hud, cars, and parts of the track. It's much worse in game than the gif shows. Vulkan Gif: https://gfycat.com/TatteredPowerfulFlickertailsquirrel Software Gif: https://gfycat.com/CorruptHopefulAbyssiniangroundhornbill

inactive123 commented 7 years ago

BTW, to anybody involved -

Please state which GPU you have, which OS you are running, and also, which video driver you are running. This is very important since many Vulkan drivers are still in a premature state of development right now. Bugs can and will happen in commercial drivers, and it could be that a glitch could happen on one GPU driver yet it doesn't happen on another.

inactive123 commented 7 years ago

Also, there is a very handy feature for 'dumping' an entire video recording. Posting this would be very helpful for debugging purposes. I will post instructions on how to do this soon in this thread.

simias commented 7 years ago

Lack of dithering/15bit mode is a known issue IIRC, it's because the vulkan renderer doesn't handle 15bit output at all.

andres-asm commented 7 years ago

OS: Windows 10 GPU: GTX 970 (376.33)

Tomb Raider with PGXP texture correction enabled is a mess http://imgur.com/a/VG2YE

saftle commented 7 years ago

@fr500 does that affect the GL renderer as well? If yes, I would probably add that instead to https://github.com/libretro/beetle-psx-libretro/issues/85. Is there a way we can sticky the GL, Vulkan, and PGXP threads?

andres-asm commented 7 years ago

Ok don't mind me, it happens in GL too with PGP texture correct so the issue is not Vulkan's

inactive123 commented 7 years ago

I don't get those issues with Tomb Raider and perspective correction + PGXP on Linux.

It seems like we still have a truckload of GL state errors that manifest themselves differently on each OS/GL driver. Hopefully simias can figure this out.

InnocentHawk commented 7 years ago

Air Combat

Region/Version: USA

Core Options: As per first post Core Version: f12cc2f (I assume this is correct, using latest build from December 15th) Graphics Card: R9 280X Driver Version: 16.9.2 (There was a new stable release driver on the 8th but I haven't upgraded yet, probably will soon) OS: Windows 7 SP1 64-bit

Bug Description: The game shifts from 240p to 480i, and this causes a momentary visual corruption when you press start to skip the opening cutscene, and then also corrupts the main menu which further corrupts scrolling text of the first story cutscene. Creating a save state and reloading it fixes the scrolling text.

Vulkan Screenshots: (Short pause of last visible frame of cutscene after pressing start) https://cloud.githubusercontent.com/assets/8392067/21291097/61cd83b6-c499-11e6-83c4-ca2a5bf0ad97.png (Last visible frame becomes corrupted) https://cloud.githubusercontent.com/assets/8392067/21291266/106aab3e-c49e-11e6-8ecd-d563e8f76535.png (Last visible frame of main menu) https://cloud.githubusercontent.com/assets/8392067/21291280/54b98a26-c49e-11e6-816b-a83c414ebb66.png (Last visible frame becomes corrupted) https://cloud.githubusercontent.com/assets/8392067/21291284/8d1e1d96-c49e-11e6-82a8-fd3590066916.png (Scrolling text is corrupted) https://cloud.githubusercontent.com/assets/8392067/21291286/a0125854-c49e-11e6-8004-c6017b8da65b.png (Scrolling text fixed after loading save state) https://cloud.githubusercontent.com/assets/8392067/21291288/aa48d316-c49e-11e6-8f97-fb6a3c973407.png

Software Screenshot: https://cloud.githubusercontent.com/assets/8392067/21291291/c3d3d11e-c49e-11e6-857c-91d77e608149.png

DukeJP commented 7 years ago

Soul Blade (USA)

Windows 10 64 bits Core Version: f12cc2f Core options : as first post GPU: Nvidia 640gt with last drivers, 376.19

In Li Long Stage have this problem with the water: http://imgur.com/2TTrsNX

In the 2x resolution, its worse: http://imgur.com/eVjr9dT

CORRECT GRAPHICS: http://imgur.com/6Zr8Iiq

senolfeldmann commented 7 years ago

Crash Bandicoot - Warped (USA)

Core Options: As per first post Core Version: aafafde Graphics Card: AMD R9 280X Driver Version: 16.11.5 OS: Windows 10 64-bit

Bug Description: Actually, there are two bugs I have discovered in this game. First, the shadow of Crash is not rendered properly, instead of a clean black shadow it has these kind of lines in it. This is even worse when you use a higher internal resolution. It always is like this, not just only on specific floors/level areas.

The second bug: Dithering does not work at all. This is seen when you look at the water on the ground and in the sky.

Here are the images: http://imgur.com/a/XwYoQ

inactive123 commented 7 years ago

I can confirm the current flickering/non-rendering GL issues that happen right now in games like FInal Fantasy VIII/Tekken 3/Dead or Alive 1 etc. These issues did not happen before.

@simias I assume it's an interlaced video issues since all three of these games use interlacing at those exact sequences (FFVIII battle menu has interlaced text / status indicators on top of the 3D battle environment, Tekken 3 and DOA1 run at high-res interlaced resolutions, etc.) It's definitely a regression that didn't happen before with the GL renderer.

Gagert commented 7 years ago

I have tested four different games with the mednafen psx hw core:

Frogger Hogs of War Spyro the Dragon Tekken 3

While testing those games, I have applied the following settings for the various tests:

Test 1: Software (RetroArch video driver: gl, mednafen psx hw: software)

Shaders: OFF
Software Framebuffer: ON
Adaptive Smoothing: OFF
CD Image Cache: OFF
CPU Overclock: OFF
Skip Bios: OFF
Widescreen Mode Hack: OFF
Internal GPU Resolution: 1x
Texture Filtering: Nearest
Internal Color Depth: Dithered 16px (native)
Scaled dithering pattern with internal resolution: OFF
Dithering Pattern: 1x (Native)
PGXP Operation Mode: OFF
PGXP Vertex Cache: OFF
PGXP Perspective Correct Texturing: OFF
Initial Scanline: 0
Initial Scanline PAL: 0
Last Scanline: 239
Last Scanline PAL: 287
Frame Duping (Speedup): OFF
Crop Overscan: ON
Offset Cropped Image: OFF
Additional Cropping: OFF

Frogger http://imgur.com/ZIqvOLq http://imgur.com/5bPH7LC

Hogs of War http://imgur.com/S4SXPnv

Spyro the Dragon http://imgur.com/XTla5CV

Tekken 3 http://imgur.com/aR1lvH1

Test 2: Vulkan (RetroArch video driver: vulkan, mednafen psx hw: vulkan)

The same settings as above but with the Vulkan api

Frogger http://imgur.com/RldtU9r http://imgur.com/FW1FPOB

Hogs of War http://imgur.com/XjHHSHt http://imgur.com/0MFcXPz

Spyro the Dragon http://imgur.com/UkJQatf

Tekken 3 http://imgur.com/D0nROnN http://imgur.com/0MeSvmV

Test 3: Vulkan 4X (RetroArch video driver: vulkan, mednafen psx hw: vulkan)

Internal GPU Resolution: 4x

Frogger http://imgur.com/U1roNdD http://imgur.com/eiM2n9R

Hogs of War http://imgur.com/C4tFdGc

Spyro the Dragon http://imgur.com/X8n9gQc

Tekken 3 http://imgur.com/obRXUva

Test 4: Vulkan 4X PGXP mem only (RetroArch video driver: vulkan, mednafen psx hw: vulkan)

Internal GPU Resolution: 4x PGXP Operation Mode: memory only PGXP Perspective Correct Texturing: ON

Frogger http://imgur.com/SPaOyJb http://imgur.com/9I9kbFy

Hogs of War http://imgur.com/bg80z3I http://imgur.com/kDnstzG

Spyro the Dragon http://imgur.com/ZJPAS9L http://imgur.com/hRe69hM

Tekken 3 http://imgur.com/vqEw7Cw http://imgur.com/Xe9enIB

Test 5: Vulkan 4X PGXP mem & cpu (RetroArch video driver: vulkan, mednafen psx hw: vulkan)

Internal GPU Resolution: 4x PGXP Operation Mode: memory & cpu PGXP Perspective Correct Texturing: ON

Only tested one game with these settings:

Spyro the Dragon http://imgur.com/e2zIZXi

My PC specs: Intel i7-4790K @ 4.0 Ghz, 16gb RAM, GeForce GTX 1080 (378.66 driver), Windows 10 64-bit, RetroArch 1.4.1, mednafen psx hw 0.9.39.2 2613b5f

daninthemix commented 7 years ago

Texture filtering doesn't work at all, regardless of type. Would be great if this could be implemented.

inactive123 commented 7 years ago

Texture filtering has only been implemented for the OpenGL renderer so far. I'd have to ask @TinyTiger to look into this for the Vulkan renderer. And there is the question whether he'd even want to do it because he might prefer adaptive smoothing for whatever reasons.

daninthemix commented 7 years ago

Adaptive smoothing is indeed amazing - in fact the most amazing feature about the Vulkan PSX renderer, imo - but you still get pixellated textures on 3D surfaces without texture filtering.

hizzlekizzle commented 7 years ago

I have some ideas for where texture filtering would be added into the vulkan renderer but I don't have the hardware to actually test/implement it.

daninthemix commented 7 years ago

@fr500 those Tomb Raider PGXP errors are different for me - or rather, they're the same on Vulkan (flickering black textures on Lara), but on GL she has brown legs (!). If I disable perspective correct texturing (on Vulkan), the black textures are gone but the (correct) textures flicker and shimmer like crazy. Would love to see PGXP truly fixed for this game, as it seems to work perfectly for TR2 and TR3.

saftle commented 7 years ago

@daninthemix Please post your findings in the PGXP thread: #85 There are other bug reports there as well.

daninthemix commented 7 years ago

@twinaphex I'd be willing to put a bounty on Vulkan texture filtering, if you're happy to open a new issue for it.

Aerocatia commented 7 years ago

A few games like CTR still have aspect ratio problems, especially PAL ones. Any news on that?