libretro / beetle-psx-libretro

Standalone port/fork of Mednafen PSX to the Libretro API.
GNU General Public License v2.0
311 stars 131 forks source link

Internal Color Depth option missing when using Vulkan Renderer #751

Open jibarofoss opened 4 years ago

jibarofoss commented 4 years ago

Description

Internal Color Depth option is missing when using the Vulkan renderer.

Expected behavior

Internal Color Depth option would be available when using the Vulkan renderer (like when using the opengl renderer) retroarch_expected

Actual behavior

Internal Color Depth option is missing when using the Vulkan renderer. retroarch_bug

Steps to reproduce the bug

Prerequisite: Set core to vulkan renderer

  1. Load Beetle PSX HW Core
  2. Boot game
  3. Go to quick menu and go into options

Bisect results

Noticed it happening about a week ago

Version/Commit

Beetle PSX HW (0.9.44.1 3ad4902) (Started to notice here) Beetle PSX HW (0.9.44.1 b432b689) (Moved to git version to see if the issue was resolved, it wasn't)

Core options

Environment information

Sanaki commented 3 years ago

Read the description of "Dithering Pattern". On vulkan, the color depth is directly tied to that setting. With it off, it's 32bpp. With it on, it's 16bpp.

keylimesoda commented 5 months ago

I'm not sure this is behaving correctly. With dithering disabled, I'm still seeing significant color banding in SH1.

image

keylimesoda commented 5 months ago

Here's another screenshot in vulkan without the CRT filter. Still some rainbow banding, but not as noticeable. image

And here's a ss in software renderer image