libretro / beetle-psx-libretro

Standalone port/fork of Mednafen PSX to the Libretro API.
GNU General Public License v2.0
311 stars 131 forks source link

Problem with new Crop Overscan #820

Closed hacls1 closed 3 years ago

hacls1 commented 3 years ago

Hi guys, there is a problem with the new Crop Overscan, before, which was more accurate, you could just chop ~8px top and bottom, that's by default the configuration of DuckStation, for example, and there you have it.

Now you pretty much crop all overscan independent of how much it is, FFIX is 8px, MGS is another, Chrono Cross another, etc.. Which is great, the problem is there's a ton of games that still display trash pixels, like Dino Crisis 2, Legend of Dragoon, etc and automatically cuting off the horizontal blackness (vertical overscan) leaves you having to config additional cropping game by game, which is a nightmare.

I suggest leaving the original option there and put some "PAL optimize" option or something like that for someone who needs it, like the "Crop Mode>All Borders" from DuckStation.

Exemplo1 Exemplo2

hacls1 commented 3 years ago

Hi, so the problem persists, I'll try to show what's happening...

This is Dino Crisis 2 - Config: Force 4:3 - Crop Overscan: On - Initial Scanline NTSC: 8 - Last Scanline NTSC: 231 = Perfect dc2-f43co231-8

But then FF9 with the same config as above = Chopping the image top and bottom (in this frame you can see only the top obviously) ff9-f43co231-8


So I remove Crop Overscan.. The 4:3 ratio is gone and the pillarbox comes to the scene in DC2... dc2-f43nco231-8

In FF9 the top and bottom mess is corrected, but there's 4:3 no more and the pillarbox comes.. ff9-f43nco231-8


Let's turn on the Crop Overscan again, but this time no chop in the scanline, Initial and Last Scanline back to standard 0 and 239 respectively.. DC2 back to 4:3, but now showing garbage pixels top and bottom.. dc2-f43co239-0

FF9 is perfect again because its naturally letterbox... ff9-f43co239-0


And if you remove Crop Overscan option and let the standard Scanlines numbers...

DC2 is 4:3 no more and shows garbage textures... FF9 is perfect but with overscan all around... dc2-f43nco239-0 ff9-f43nco239-0


In short, before, the Crop Overscan only removed the horizontal overscan leaving the vertical overscan up to you, then you just removed about 8px top and bottom and it's done. Now the Crop Overscan basically removes the pillarbox and letterbox and then what do you do with the trash pixels still being display? You'll have to config game by game.

daFourch commented 3 years ago

I'd like to +1 on this one.

Here's what the previous behaviour looked like on Heart of Darkness NTSC game :

Heart of Darkness NTSC - Beetle PSX HW - Default

Black bars were set on purpose by developpers to give the game a cinematic look.

Here's what it looks like now with the new overscan :

Heart of Darkness PAL NTSC - PCSX Rearmed

No more cinematic letterbox.

Here's what Heart of Darkness looks like on a CRT TV :

HOD43

We can clearly see the letterbox. So I assume the new Crop Overscan mode isn't accurate.

Is Crop Horizontal Overscan gone forever? Is there a way (I could have missed) to set the new Beetle PSX core to behave like the previous one, that is ONLY cropping the horizontal overscan, not the vertical one at the same time? Maybe add an option to set Horizontal, Vertical or Both?

The version I'm on is by the time of this post is : 0.9.44.1 e8609eb

Cheers

Amisaddai commented 3 years ago

I'm also having issues with the crop overscan option after updating to 0.9.44.1 When the option is enabled, I get vertical scaling issues on certain video modes (displayed below with the tvout+interlacing shader), turning the option off seems to solve it, but then horizontal scaling gets messed up across all video modes.

1

daFourch commented 3 years ago

You're not the only one thinking overscanning vertically is bad. You should push this issue here:

https://forums.libretro.com/t/problem-with-new-crop-overscan-in-beetle-psx/35283/3

ds22x commented 3 years ago

I guess I could try and cook up an additional option for people who want the old cropping behavior, while keeping the new cropping method intact.

ds22x commented 3 years ago

This can be marked as solved.