search

libretro / beetle-psx-libretro

Standalone port/fork of Mednafen PSX to the Libretro API.
GNU General Public License v2.0
311 stars 131 forks source link

Add multiple combos for the analog toggle #859

Closed bslenul closed 1 year ago

bslenul commented 2 years ago

As an alternative to #858 I'm proposing a new core option that lets you chose a combo from a predefined list, instead of hardcoding a single one:

image

image

I say that in pretty much every PR I make but I'm not a dev and there is maybe a better way to handle that, so feel free to edit the PR or to tell me what to change ;) But from my tests and @Sanaki's, it works perfectly fine!

Closes #699

bslenul commented 2 years ago

As Sanaki suggested to me on Discord, I changed it so it's now a separate option, to not break existing core options files. PR description and screenshots updated accordingly.

bslenul commented 1 year ago

Rebased + very minor cleanups.

PR has been pending for 6 months now, if there's anything wrong with it please let me know.

hizzlekizzle commented 1 year ago

@LibretroAdmin looks safe to merge AFAICT

ichee commented 1 year ago

Looks good.

I would still prefer if the default toggle was something other than L1+L2+R1+R2+Start+Select.