search

libretro / beetle-psx-libretro

Standalone port/fork of Mednafen PSX to the Libretro API.
GNU General Public License v2.0
311 stars 131 forks source link

fix #507 again #860

Closed BinBashBanana closed 2 years ago

BinBashBanana commented 2 years ago

fixed the regression in android builds caused by 3f525d7

LibretroAdmin commented 2 years ago

@BinBashBanana Hi, builds are broken now for Android ARMv7 and Android x86, please fix when you have some time. Something about GLESv3 linkage. See below -

https://git.libretro.com/libretro/beetle-psx-libretro/-/pipelines/135422

BinBashBanana commented 2 years ago

It looks like GLESv3 is only supported with android SDK 18 and later, see here. I have android SDK 33, and all 4 HW builds were successful on my computer. This could be fixed by making an exception for 32-bit android architectures, but would it be possible to upgrade your SDK minimum version on the buildbot to at least 18? (It also turns out that SDK version 21 is always the minimum version for 64-bit builds, which explains why they were able to build, see the comment on the stack overflow answer)

LibretroAdmin commented 2 years ago

We try to aim for as low a SDK level as possible for the sake of backwards compatibility with older Android versions.

You can proceed with the selective bumping of the API level for these two ABI targets. Use API level 18 so that we still cut off as few devices as possible

BinBashBanana commented 2 years ago

Is it possible to do that within .gitlab-ci.yml?

LibretroAdmin commented 2 years ago

Don't know, you'd have to tell us, not the other way around.

BinBashBanana commented 2 years ago

For now, I've just removed the OpenGL renderer from 32-bit android builds (armeabi-v7a and x86). I'll see if I can get a proper solution working for this though. PR: #861

LibretroAdmin commented 2 years ago

OK, thanks. Hopefully something can be figured out, yeah. Maybe there'd be a way of doing some linking against a GLES shim and then the actual linking takes place on the frontend (RetroArch)?