search

libretro / beetle-psx-libretro

Standalone port/fork of Mednafen PSX to the Libretro API.
GNU General Public License v2.0
309 stars 131 forks source link

Run the content for a few frames before closing tray #888

Closed bslenul closed 1 year ago

bslenul commented 1 year ago

As explained in #793 currently when switching disc you have to resume content before actually closing the virtual tray or else it won't register that it was opened in the first place. This was frustrating and super confusing for new users, resuming doesn't feel intuitive at all and it's not needed with the other PS1 cores.

With this PR the content will run for a few frames before actually closing the tray, giving the core some time to register that it was opened before.

Closes #793

bslenul commented 1 year ago

Converted to draft, while using runahead (without 2nd instance, with it it's completely broken: https://github.com/libretro/RetroArch/issues/10070) it might not work properly depending on the number of frames selected, I could just increase the number of times retro_run is ran but it feels very hacky, I'd like to find a more reliable way...

edit: Can't find any clean solution to this, so closing. Hopefully someone will be able to find a proper solution at some point.