libretro / beetle-psx-libretro

Standalone port/fork of Mednafen PSX to the Libretro API.
GNU General Public License v2.0
311 stars 131 forks source link

Core does not create folder for texture dump/replacement #892

Open SeongGino opened 11 months ago

SeongGino commented 11 months ago

Description

When using the Texture Dump feature of the HW/Vulkan core, either it/RetroArch does not create the prerequisite folder that's needed, thus errors such as provided below will appear in the log:

[libretro ERROR] failed to write to: /mnt/ChikaHa/ROMS/top-texture-dump/bcdf3632-4502e39.png

Expected behavior

Core/RetroArch should be able to create the necessary folders on its own (though preferably, shouldn't it be in retroarch's system dir?).

Actual behavior

The error above occurs, at least until the user creates said folder themselves manually and resets the core - only then does texture dumping work.

Steps to reproduce the bug

  1. Launch a game with the Beetle PSX HW core (with logging enabled)
  2. Enable Track Textures and Dump Textures/Replace Textures
  3. Unpause the game
  4. Exit/minimize RetroArch, go to the game's directory in the filesystem
  5. Get confused as to why there's no difference or folders added

Bisect results

N/A

Version/Commit

Core options

Environment information

agentduckman12 commented 10 months ago

you're supposed to make them yourself it is not made to make them itself

SeongGino commented 10 months ago

you're supposed to make them yourself it is not made to make them itself

Please direct me to where in either the documentation or the tooltip does it indicate that not creating folders and wasting an individual's time if they aren't premade using a very specific and inconvenient path and name is intended behavior.

If that somehow is intentional, then pardon the tone, but that's a bad design. Even just making folders in libretro's save or system directory would be preferable--like what the Swanstation or Mupen cores do.