libretro / bsnes-libretro

bsnes is a Super Nintendo (SNES) emulator focused on performance, features, and ease of use.
Other
11 stars 12 forks source link

Cheats - Only last selected cheat is injected #9

Open James-F2 opened 2 years ago

James-F2 commented 2 years ago

Thank you @ds22x for fixing the uppercase issue that was plaguing the bsnes core since forever! https://github.com/libretro/bsnes-libretro/commit/b30bbe57c1e55b3ace744c851b81c0656d2367e4

Reporting another critical bug with bsnes cheat system to be fixed by professionals. :) It applies cheats when I enable them once or when I press apply cheats, and then goes to loop only the last enabled cheat. So for example: I select (ON) 5 cheats, it immediately applies all of them but keeps only the last selected one in the list actually active and stop applying all cheats before it during gameplay.

Thanks!

ds22x commented 2 years ago

Did a bit more of research, and it seems that setting multiple, single line Higan/bsnes formatted codes (E.G. 00d0d8=ad or 00d0d8/ad) for infinite lives in Super Mario World) will work just fine (codes that include '+' signs will fail regardless the codetype however), while codes that need to be decoded will only apply the last decoded, probably due to how the decoding process works. Good news is that, without all the decoding coding, it will accept multi-line Higan formatted codes just fine, but that's about all the good news I can provide at this moment in time, as this implementation would make it so only the most recent enabled cheat can be disabled (and even resetting bsnes wouldn't clear the enabled cheats in this case).

James-F2 commented 2 years ago

Can't wait to finally be able to enjoy bsnes on retroarch with working cheats. 🥺

James-F2 commented 1 year ago

For some reason bsnes doesn't apply all the enabled cheats recursively like snes9x does, only the last one. This is also true for the "Auto-Apply Cheats During Game Load" option, when I load a game it only applies the last "ON" cheat.

James-F2 commented 1 year ago

Anyone? Nobody using cheats with bsnes?