libretro / bsnes

Super Nintendo (Super Famicom) emulator
https://bsnes.byuu.org
Other
11 stars 13 forks source link

a not-quite cosmetic problem in shader handling #12

Closed galtgendo closed 4 years ago

galtgendo commented 4 years ago

There's a little bit of code, that while works, it could use a bit of semi-trivial error handling.

In ruby/video/opengl/surface.hpp, you should consider adding if (fooVertex != -1) for all three glEnableVertexAttribArray/glVertexAttribPointer blocks and the three final glDisableVertexAttribArray calls.

Without the condition, the calls fail silently, but why make them in the first place then.

rtretiakov commented 4 years ago

This is something that should be posted in the upstream repository. This one is for libretro issues only.

galtgendo commented 4 years ago

... One problem with that: reporting issues on main is restricted to contributors only.

galtgendo commented 4 years ago