search

libretro / bsnes

Super Nintendo (Super Famicom) emulator
https://bsnes.byuu.org
Other
10 stars 13 forks source link

Can't disable HD Mode 7 Scale #46

Open SilverKeeper opened 3 years ago

SilverKeeper commented 3 years ago

Currently you can disable every HD Mode 7 related setting, except for the scale. This renders Retroarch's shaders useless, as HD Mode 7 does something to the output even at Scale 1x.

Tested in Windows 8.1 x64, Retroarch 1.9.0 stable.

DerKoun commented 3 years ago

Unlike bsnes-hd bsnes does disable HD Mode 7 completely when 1x scale is set. Could you elaborate on "does something to the output" and "renders Retroarch's shaders useless", maybe show screenshots?

SilverKeeper commented 3 years ago

Unlike bsnes-hd bsnes does disable HD Mode 7 completely when 1x scale is set. Could you elaborate on "does something to the output" and "renders Retroarch's shaders useless", maybe show screenshots?

mesen-s bsnes

Don't know how else can I explain it. That's Zombeaver's .cg Razorgirl shader, using "gl" driver. The first pic is from Mesen-S, second from bsnes. It's completely broken in the bsnes core, but it works fine in the (former? I don't see it in the core downloader) bsnes-hd core, where I can turn HD Mode 7 off. bsnes-hd has other oddities, whoever, like the Overscan option doing nothing.

DerKoun commented 3 years ago

To be honest, I see very little difference between the two screenshots. But I'm not into CRT shaders, so I may not be qualified. About bsnes-hd: It is back on the auto updater again. And the "overscan" option is different from bsnes, see https://github.com/DerKoun/bsnes-hd/blob/master/README.md#differences-in-settingoptions-from-bsnes , but should definitively not do nothing.

SilverKeeper commented 3 years ago

To be honest, I see very little difference between the two screenshots. But I'm not into CRT shaders, so I may not be qualified. About bsnes-hd: It is back on the auto updater again. And the "overscan" option is different from bsnes, see https://github.com/DerKoun/bsnes-hd/blob/master/README.md#differences-in-settingoptions-from-bsnes , but should definitively not do nothing.

I thought the horrible chromatic aberration was pretty obvious. Focus on the health bar, this time. (I'm watching these on a 1080p screen) I've tried disabling every option in bsnes, but the only difference is that disabling both "PPU" and "DSP" Fast Mode makes it look like this: Mega Man X (USA) (Rev 1)-210117-144746 We discussed it briefly in the Libretro Discord, and Zombeaver said there must be something very wrong with the core, since bsnes-mercury (accuracy) doesn't have this issue. Regarding bsnes-hd; granted, it doesn't seem to be focused on keeping a resolution friendly towards shaders, given its main purpose, so forget I mentioned it. (the mask doesn't look correct even at 4:3 through Retroarch's scaling, and Show Overscan ON or OFF in core options)

DerKoun commented 3 years ago

I see what you mean. I don't think I can help there, sorry. I mainly answered because it may be related to HD Mode7 and I pay attention to such issues as they may help me improve bsnes-hd. For exampled I added the separate scale values "1x" and "disable" because of people requesting it for shaders (among other reasons). I assume the "mask" issue with bsnes-hd is because it outputs 224 or 216 lines but the shader may expect 240. I'll make a note to also allow 240 lines again. And now I'll stop side-tracking this issue.