search

libretro / bsnes2014

Libretro fork of bsnes. As close to upstream as possible.
GNU General Public License v3.0
9 stars 17 forks source link

Allow setting GIT_VERSION #28

Closed orbea closed 7 years ago

Alcaro commented 7 years ago

I think ?= defaults to =, not :=, if the variable isn't set.

Not sure if it matters. Probably doesn't.

orbea commented 7 years ago

It does matter for my slackbuild scripts as it does for ubuntu/debian.

Please see the discussion here. https://github.com/libretro/libretro-2048/pull/21

Alcaro commented 7 years ago

That's not what I'm asking about, I'm asking about the lazy vs eager evaluation of = vs :=.

I'm pretty sure ?= is ignored if there's a command line argument, anyways. Maybe different make implementations or versions behave differently.

orbea commented 7 years ago

Yea, exactly. Its a very small nitpick, but being able to avoid the following seems worth it to me if its so easy. Thanks for the merge. :)

fatal: Not a git repository (or any parent up to mount point /tmp)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).