Adding VFS support - Githubissues

claudiuslollarius commented 6 years ago

Added VFS support to core.

A few points to note:

It seems to me core needs file truncation to work (what for I have no idea - NDS roms should be read only), so I added the functionality (one call) to the VFS and bumped its version to 2. Added the function pointer at the end of the VFS interface struct so that it's backwards compatible with previous one. If I'm mistaken and core does not need file truncation to work with Retroarch/Libretro I'd be happy to get rid of the VFS changes
Core seems to use stat to get last modification date for save states. I don't think this is surfaced in any way in Retroarch/libretro so I just set the date to zero when building for libretro. Better than trying to add stat too to the VFS I thought.

Tested against current Retroarch without VFS v2 support, which means fallback implementation (which is what RetroArch would end up using) should work.

inactive123 commented 6 years ago

@bearoso Would appreciate if you could give this a quick look.

bearoso commented 6 years ago

This doesn't build for me on Linux. There's one section that stat_utf8 is used when _WIN32 isn't defined, but it was removable. The big problem is all the ambiguity with the fclass functions in emufile.h. Whatever's getting by with MSVC isn't going to fly with other compilers. That needs to be more thought out, not poked at until it sort of works.

claudiuslollarius commented 6 years ago

@bearoso I have reworked the PR to work around the ambiguities between emufile and stdio: now codebase compiles and runs using either GCC or MSVC.

bearoso commented 6 years ago

I still need to remove the #ifndef _WIN32 block in ROMReader.cpp:STDROMReaderInit to compile. You can probably delete it, because I don't think it's necessary.

Personally, I would've just replaced the stdio file functions with the rfile functions universally and removed the aliases. But it does work now.

claudiuslollarius commented 6 years ago

@bearoso Ok, removed the code block in STDROMReaderInit as you recommended.

claudiuslollarius commented 5 years ago

@twinaphex Any idea if this can move forward?

bearoso commented 5 years ago

Whoops, sorry about forgetting you. It works fine now, so I'll merge it.

libretro / desmume

Adding VFS support #46