search

libretro / desmume

DeSmuME is a Nintendo DS emulator
http://desmume.org
GNU General Public License v2.0
35 stars 33 forks source link

Emscripten port fails now #50

Open inactive123 opened 5 years ago

inactive123 commented 5 years ago

http://p.0bl.net/27619

Seems to be related to the VFS/filestream updates.

bearoso commented 5 years ago

I'm totally unfamiliar with emscripten, so I'm not really the best choice to fix this.

But, from what I can see, it looks like more conflicts with the fwrite, etc. and rfwrite, etc functions.

I see a couple ways of remedying this properly:

  1. Rename the member functions that are named after the std functions.
  2. Just use the rf prefix functions everywhere instead and nix the #defines. This is the way I took with fopen_utf8 before the vfs merge. It would make pulls from upstream more difficult, but is definitely more compatible.