libretro / docs

This is a repo of the RetroArch official document page.
https://docs.libretro.com/
MIT License
249 stars 405 forks source link

libretro-build-ios-arm64.sh crashes if current path has a space in it #889

Closed smorkin closed 5 months ago

smorkin commented 7 months ago

Describe the bug Follow the instructions to build the cores yourself. After downloading, the next step is to run

./libretro-build-ios-arm64.sh

If the current path has a space, the script immediately crashes.

Expected behavior/changes No crash.

Additional context The last line in the script is

platform=ios-arm64 ${BASE_DIR}/libretro-build.sh $@

and this is where it crashes. However, changing the line to

platform=ios-arm64 "${BASE_DIR}/libretro-build.sh" $@

stops the immediate crash, but something still goes wrong later. If the current path is.e g.

/Users/simon/Development code/RetroArch/libretro-super

running the modified script will result in a file being created with the name

/Users/simon/Development

which is filled with log output. I suspect a called script somewhere is also not handling spaces in the path and tries to log something to a file in the path, but instead creates this log file at the broken path.