search

libretro / dosbox-libretro

Port of DOSBox (upstream) to the libretro API.
GNU General Public License v2.0
61 stars 40 forks source link

This core is now not required #122

Open andres-asm opened 5 years ago

andres-asm commented 5 years ago

I have added the "sdl removing" stuff to my core (optional) thanks to @m4wx, and now the core works even on WiiU and Switch (tested).

It also compiled for emscripten but that needs someone to update the html so it can load the core. That makes this core effectively pointless.

I'd be willing to fix build errors for SVN if there are any. I sent PRs to enable it for WiiU and Vita. Also I benchmarked SVN and this with X86_64 and dynrec and cycles MAX for some reason SVN is able to kick the cycles automatically and this one isnt:

SVN image

This image

I'd prefer if this core was deprecated so I don't have to keep them in-sync.

andres-asm commented 5 years ago

To build with fake SDL just do WITH_FAKE_SDL=1

andres-asm commented 5 years ago

It builds and loads for emscripten too image

Though it crashes:

image

Not sure how to fix that anyway, that's an issue for another day

andres-asm commented 5 years ago

https://github.com/fr500/dosbox-svn/commit/b5a5ef323d10765860b3c2bb38caf98e2788fbb5

ehmry commented 5 years ago

What is the difference between https://github.com/libretro/dosbox-libretro and https://github.com/fr500/dosbox-svn?

stellarporter commented 5 years ago

https://github.com/libretro/dosbox-libretro seems outdated enough with official svn but supports genode, and maybe has a few QoL tweaks not in fr500 fork. Libretro side possibly uses some stale code from initial porting days, that could make it harder to add things.

https://github.com/fr500/dosbox-svn is constantly up-to-date with upstream fixes and supports most major platforms. Looks to support extra Dosbox features like variable refresh rates. Libretro side is rebuilt and better structured for future things. Check the libretro branch. This one is a winner.

andres-asm commented 5 years ago

I can backport any makefile changes and I'd be willing to accept PRs to genode or whtever.

I don't think there is anything in the old port that I don't support.

ehmry commented 5 years ago

Ok, maybe this weekend I will transition.

Gagert commented 4 years ago

The links seem outdated for this newer DOSBox SVN libretro core (got me confused initially).

https://github.com/libretro/dosbox-svn/tree/libretro this is the new link for those who do not know (the libretro branch of dosbox-svn, defaults to the non-libretro master branch while entering dosbox-svn from a search engine/github search and such).