search

libretro / dosbox-libretro

Port of DOSBox (upstream) to the libretro API.
GNU General Public License v2.0
61 stars 40 forks source link

Add back install and uninstall rules #97

Open alice-mkh opened 5 years ago

alice-mkh commented 5 years ago

They were removed in 3435b2669e745efa8d1540a5c245e0f8a1ef6ab0

Kekun commented 5 years ago

The GNOME Games Flatpak installation relies on these rules to be there so I can't approve that MR more.

andres-asm commented 5 years ago

Ah, it wasn't intentional, practically rewrote the core based on my new dosbox-svn core, sorry.

On Thu, Aug 9, 2018 at 11:34 AM Adrien Plazas notifications@github.com wrote:

We rely on these rules for GNOME Games' Flatpak installation.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/libretro/dosbox-libretro/pull/97#issuecomment-411819569, or mute the thread https://github.com/notifications/unsubscribe-auth/ABpC0Ekv4MXqYWZc6M687gGCcVE0DNowks5uPGSlgaJpZM4V2BaR .

Kekun commented 5 years ago

Any news? GNOME Games depends on this fix. :(

andres-asm commented 5 years ago

You probably should add them too fr500/dosbox_svn instead, it's a faster core (and I can merge it there)

alice-mkh commented 5 years ago

fr500/dosbox_svn seems to introduce SDL dependency, which isn't ideal for us. Any reason not to merge this, considering other PRs are being merged?

andres-asm commented 5 years ago

I have no idea I have no control over libretro repos. It introduces SVN because dosbox has always used SVN for many things (timers, threads, CD-ROM)

alice-mkh commented 5 years ago

Ah, and you're the only person besides Adrien who received a notification. Sorry :(

As for dependency, aren't libretro cores meant to be self-contained? I.e. I don't know any other core that has external dependencies (not saying there aren't any, just I don't know any :D)

@twinaphex since you're the person who merged the last MR here, mind taking a look at this one?

escalade commented 5 years ago

@Exalm

External libraries can be compiled in statically, lots of cores do this AFAIK.

@fr500

I think only SDL_sound (mp3/wav/aiff track support) is used for CDROM, right?

BTW there's a very good SDL2 port that I've been using for a long time here: https://github.com/duganchen

Sorry for the off topic, just thought it may be interesting.