search

libretro / dosbox-svn

GNU General Public License v2.0
6 stars 17 forks source link

PS3 Build fix #67

Closed crystalct closed 3 years ago

realnc commented 3 years ago

I'm going to make a couple comments for minor changes shortly, but before that here's how to properly commit the changes in git:

Instead of creating new commit, you should just amend the current commit. For example:

git add  libretro/libretro_dosbox.h
git commit --amend

Since you are changing an existing commit, you need to force push to your repo:

git push --force

GitHub will recognize the forced push and will update the PR automatically.

If you are in a situation like in the previous PR where you had several commits and you want to squash them, you would do:

git rebase -i <commit just prior to your first one>

then mark the subsequent commits after your first one with f (meaning "fixup"). This will squash them and then you could have forced pushed.

crystalct commented 3 years ago

All done. Thanks for the patience :P

crystalct commented 3 years ago

Last minute modification: added CXXFLAGS += -D__STDC_LIMIT_MACROS so g++ knows macros UINTPTR_MAX and SIZE_MAX

realnc commented 3 years ago

Other than the last nitpick, looks good. I'll merge it afterwards. :-)

Btw, are these fixes intended for PSL1GHT?

crystalct commented 3 years ago

Done. About PSl1GHT, untill psl1ght Retroarch layer doens't work, cores can work only compiled with old Sony SDK. When PSL1GHT version of Retroarch will be accetable, we can adjust PSL1GHT compilations with pleasure.

realnc commented 3 years ago

Thanks! Merged. You probably intend to do a PR on libretro-super to enable the build on the buildbot?

crystalct commented 3 years ago

Since long time, i'm asking to retroarch guys to reopen PS3 compilations and downloads.... PS3 version is hosted by xbins.orgs and they stopped since August 2020.