search

libretro / dosbox-svn

GNU General Public License v2.0
6 stars 17 forks source link

libretro: Update gitlab ci extends ordering #68

Closed webgeek1234 closed 3 years ago

realnc commented 3 years ago

I don't understand this PR. Can you explain?

webgeek1234 commented 3 years ago

It's fixing and simplifying the script flow. The extends priority is 'last one wins'. When I did the initial example for the libretro infra, my intent was to have platform templates with default variables that can be overridden as needed, but I didn't understand the priority ordering. And before I figured it out, that example was copied to all cores. A recent change I made to the android template caused all cores to fail to build if JNI_PATH != . , so I'm PRing fixes to all the ones that need it, simplifying all paths for the core at the same time.

realnc commented 3 years ago

Right. Thanks!