search

libretro / fbalpha2012

Final Burn Alpha 2012. Port of Final Burn Alpha to Libretro (0.2.97.24).
30 stars 50 forks source link

Remove unimplemented Neo Geo BIOSes #104

Closed vaguerant closed 1 year ago

vaguerant commented 3 years ago

Figured out what was causing #101; it looks like at some point somebody tried to add support for Neo Geo BIOS revisions that weren't dumped this far back in FB Alpha history. Nothing very exciting, just things like the 4-slot USA variant, etc. These BIOSes aren't included in FB Alpha's Neo Geo driver this far back, so they were creating a mismatch where the RetroArch frontend had more BIOSes to choose from than the driver actually supported, so that (e.g.) selecting UniBIOS 4.0 (which libretro.cpp considered to be 0x13) would in fact run using UniBIOS 2.3 (which d_neogeo.cpp, the Neo Geo driver, considered to be 0x13).

There's really two ways this could have been fixed: adding all the more recently dumped BIOS revisions from newer FB Alpha/Neo into the Neo Geo Driver, or removing them from the libretro side. I went with the latter option because it was easier and brings the code back in-line with what fbalpha2012_neogeo does (supporting only the BIOSes that FB Alpha did in 2012-or-whereabouts, plus the extra UniBIOSes). As "new" BIOSes go, only the UniBIOSes are particularly interesting, adding cheat codes and other new features. I don't think it's worth adding any of the others to this core or the standalone Neo Geo core.

ZacharyFoxx commented 3 years ago

Hello,

First of all, thanks for your improvements at fbalpha2012. This is a useful core for those who run the backarch on old devices.

Do you think this problem has something to do with another strange behavior: In this case, even if we set the bios option for dip switch and set the bios for unibios in any version, when we run a neo rom for the first time, the core uses the version "MVS Asia / Europe ver. 6 (1 slot)"

inactive123 commented 3 years ago

@ZacharyFoxx Let me know if this should be merged.

vaguerant commented 2 years ago

Just in case there was some confusion on this, I don't believe @ZacharyFoxx was saying this PR caused that other issue, just that there is an additional issue. IIRC, this PR didn't help or hurt that other issue, but it's been a while since I looked at it.