Closed dannbuckley closed 7 years ago
We should get rid of # Generic ARM (armv)
Is HAVE_NEON used somewhere? We have a lot of garbage in these makefiles from Ctrl+C & Ctrl+V from another makefiles
I removed the Generic ARM build stuff. As for HAVE_NEON, I do not know because I am not familiar with the source code for this project.
grep -r "HAVE_NEON"
I can find it only in the Makefile, it's not being used.
You removed EXE_EXT=.exe, makefile needs it in some places. Put it after line 8
Are you sure "make platform=rpi3" will work? You need a:
ifneq (,$(findstring unix,$(platform)))
in line 37. Take a look again in the changes I did in the other makefiles.
Ok, the latest commit should fix things. (Sorry, I'm not that experienced with Makefile)
Why did you removed this?
else ifneq (,$(findstring armv,$(platform)))
override platform += unix
Several packages/scripts use "make platform=armv" yet, you'll broke them without that.
Test all the "make platform=xxx" you changed, make sure they are working.
I have confirmed that all of the areas that I altered build without error.
@twinaphex Can you merge this with the master branch?
Which master branch? You mean merging this PR or something else?
I mean merging this PR.
@sergiobenrocha2 Tell me if this is ready to be merged and I'll do it.
Yeah I think so
I optimized the build for the unix systems and removed "system_platform" since it wasn't being used by anything.