libretro / fbalpha2012_neogeo

Final Burn Alpha 2012. Port of Final Burn Alpha to Libretro (0.2.97.24). Standalone core for Neo Geo.
12 stars 30 forks source link

Add support for UniBIOS 3.1, 3.2 and 3.3. #31

Closed vaguerant closed 5 years ago

vaguerant commented 5 years ago

A few years ago I made a PR adding support for 3.1 but it seems to have been lost in a refactor at some point as the current codebase is back to 3.0 only.

inactive123 commented 5 years ago

Hey there @vaguerant , nice to see you again!

Sure, let me merge this for you.

vaguerant commented 5 years ago

I apologize, this PR is broken, it actually somehow caused fbalpha2012_neogeo to default to UniBIOS 2.2. I tried to identify the problem but wasn't able to find what I've done wrong here. Recommend undoing the commit until this can be implemented correctly.

EDIT: I've made a second PR, #32, which should hopefully fix my mistake here.