libretro / fbalpha2012_neogeo

Final Burn Alpha 2012. Port of Final Burn Alpha to Libretro (0.2.97.24). Standalone core for Neo Geo.
12 stars 30 forks source link

Fix kof2003 #50

Closed jdgleaver closed 4 years ago

jdgleaver commented 4 years ago

There is at present a Wii-specific crash fix for the game The King of Fighters 2003 - on this platform, the kof2003Callback() function is copied from the 'latest' FBA code, while everywhere else it uses the 2012 version.

It turns out that this fix is required on all platforms. The 'old' implementation of this function includes memory access violations that cause undefined behaviour. It just so happened that this produced an obvious crash on the Wii, but silent corruption happens everywhere - sometimes the game just doesn't work properly, sometimes RetroArch crashes at a random point after closing the content. Nasty stuff.

This PR just removes the Wii-specific #ifdef, so The King of Fighters 2003 now works on all platforms.