libretro / flycast

Flycast is a multiplatform Sega Dreamcast emulator. NOTE: No longer actively developed, use upstream repo for libretro from now on - https://github.com/flyinghead/flycast
http://reicast.com
GNU General Public License v2.0
155 stars 77 forks source link

Revert the KoFXI Mali fix again #1058

Closed bslenul closed 3 years ago

bslenul commented 3 years ago

This reverts 574d009cab85402f294d4f6cbb2ea7d51a455a62 as it causes a lot of graphical issues in GL, see #1022 for example, it was reverted once before because of that (2a3b0efd3d5241babe9ae88838fd60292030f9b5) but was reintroduced recently.

inactive123 commented 3 years ago

We can't really move forward with this codebase though if we have to constantly revert backported commits back. The goal is eventually to be at parity with upstream again.

I will merge it in the meantime.

bslenul commented 3 years ago

Yeah I understand perfectly, it must be frustrating but atm this commit is doing more wrong than good, fixing a single game for 2 specific mobile GPUs and having multiple games broken on multiple platforms in return doesn't seem like a fair trade for the users :p

Also I tried reproducing in standalone to see if there was another commit fixing this issue, but it's not happening there (using same settings, same game, same video driver) :/