libretro / flycast

Flycast is a multiplatform Sega Dreamcast emulator. NOTE: No longer actively developed, use upstream repo for libretro from now on - https://github.com/flyinghead/flycast
http://reicast.com
GNU General Public License v2.0
155 stars 77 forks source link

Star Wars Pod Racer - lens flare from the suns missing #38

Open Tatsuya79 opened 6 years ago

Tatsuya79 commented 6 years ago

In pod racer when the race starts in Tatooine (1st race), the 2 suns are missing in the sky while they're visible in NullDC. (standard Reicast and OIT too)

Also just an observation, you can see on the globe after selecting your pilot that the transparency is done at a higher precision than NullDC using Reicast OIT.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/59482209-star-wars-pod-racer-lens-flare-from-the-suns-missing?utm_campaign=plugin&utm_content=tracker%2F49543223&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F49543223&utm_medium=issues&utm_source=github).
inactive123 commented 6 years ago

Hi @flyinghead, let me know if this is a problem only with the OIT renderer in reicast libretro or if this happens in your fork as well.

flyinghead commented 6 years ago

Hi @twinaphex. I'll be traveling for the next two weeks so I won't be able to work on this until I get back. Sorry

Raph

On 10 Jun 2018, at 14:59, Twinaphex notifications@github.com wrote:

Hi @flyinghead, let me know if this is a problem only with the OIT renderer in reicast libretro or if this happens in your fork as well.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

inactive123 commented 6 years ago

@flyinghead No problem man, once you're back and you have time to spare, I'll try talking to you again.

Just for reference -

https://www.youtube.com/watch?v=8YQfQCHOisE

I think this is the sun that @Tatsuya79 is referring to. And yeah, I can't see it either with the OIT renderer. So it seems to be a remaining display bug.

inactive123 commented 6 years ago

@flyinghead This still doesn't seem to render, so it could still be an interesting edge case issue worthy of investigation for future rendering improvements.

flyinghead commented 6 years ago

Some info about this issue: it doesn't seem to be a rendering problem. All forks including upstream have the same problem. The suns are there but their vertices alpha value is 0 so they are invisible. It doesn't seem to be a TA parsing problem either since I can see the 0 alpha value in the main RAM. Yet redream, including the open source version, doesn't have this problem. TBC...

inactive123 commented 6 years ago

Maybe skmp stubbed out some code in the past that leads to this sun no longer showing, similar to the Z values for mod volumes?

Or maybe a regression happened in the past when going from nullDC to Reicast? Assuming nullDC showed this properly?

flyinghead commented 6 years ago

As far as I can tell, these zero alpha values seem to come from the game. So it's not in the TA parsing code nor in the renderer. But I must say I'm running out of idea.

Tatsuya79 commented 6 years ago

If that can be of any help, that's my cfg with NullDC where the suns are visible.

I noticed "Emulation.AlphaSortMode=2" and I tried different values in reicast internal settings but I think they were all causing issues and were not usable.

flyinghead commented 6 years ago

The suns will magically appear if DisableDivMatching is on.

inactive123 commented 6 years ago

Yep, the suns show up now.

inactive123 commented 6 years ago

@flyinghead While it's kinda hard to see here -

https://www.youtube.com/watch?v=8YQfQCHOisE

I think what this is still missing is lens flares being cast from the sun.

flyinghead commented 6 years ago

Yep, I can see them in the video.