search

libretro / flycast

Flycast is a multiplatform Sega Dreamcast emulator. NOTE: No longer actively developed, use upstream repo for libretro from now on - https://github.com/flyinghead/flycast
http://reicast.com
GNU General Public License v2.0
155 stars 77 forks source link

Having mixer enabled causes Flycast to crash RA when entering/exiting menu #885

Open klepp0906 opened 4 years ago

klepp0906 commented 4 years ago

OOF. took me a minute to make the connection. This is the second core ive ran into this with.

If you have mixer enabled and pause when in menu enabled entering/exiting the RA menu will crash.

Here is my issue regarding the PPSSPP core https://github.com/libretro/RetroArch/issues/9773. I assumed it was purely the mixer, however @fr500 made the connection to it being entangled with the "pause when in menu" setting via an issue of his own he had opened up https://github.com/libretro/RetroArch/issues/9787

Now that ive ran into this on a second core, maybe it'll make tracking it down a little easier if theres something ppsspp and flycast do the same to that end.

klepp0906 commented 4 years ago

doesnt happen using WASAPI, only xaudio

flyinghead commented 4 years ago

I have a theory about what's happening here. Do you have Threaded Rendering enabled in the core options? Could you try with it disabled and check if the crash still happens?

Thanks

klepp0906 commented 4 years ago

just got up, disabled threaded rendering as suggested and you were correct. Does not happen with that off.

at current ive been using a cfg override to disable the mixer when launching that core. does your hypothesis being correct mean a fix will be in the pipes at some point, or i should continue using the override? Or is disabling threaded rendering a better (temp?) solution?

Its on by default and says recommended so i imagine thats not the case.

also worth noting that when going in and out of a game with F1 to the RA menu if i have threaded rendering on, it the audio during the transition will be garbled/crackle'y and will crash either immediately or after a few back and forths. With it off, the crashing stops, but so does the garbled audio on the transition which is obviously not ideal.

tried all sound drivers other than xaudio and while wasapi doesnt seem to have the issue, it has problems of its own, and exclusive mode takes away my ability to watch youtube or use discord while i game. sdl just did nothing. and dsound somehow for some reason slowed my pc to a crawl.

its xaudio or bust for me. Btw, while youre here and in the know.. is xuadio = xaudio2?

also does ppsspp have a setting tantamount to threaded rendering?

flyinghead commented 4 years ago

When using Threaded Rendering, the emulator runs in its own thread and produces audio asynchronously. When opening the RA menu, it will continue outputting audio briefly before stopping. My guess is that there's some multi-threading issue with xaudio and mixer enabled and that causes a crash.

There is no easy fix to this issue unfortunately and it might have to be fixed on the RA side rather than in the core.

Whether to disable the mixer or Threaded Rendering is up to you. If your machine is fast enough, disabling Threaded Rendering shouldn't be a problem in most cases. (it used to be the default until very recently.)

I'm not familiar with ppsspp internals so I don't know if it has an option similar to Threaded Rendering. And yes, xaudio = xaudio2.

klepp0906 commented 4 years ago

excellent. I appreciate all the info. I'll reference this over in the other thread in case anyone who wants to address it RA side can (if thats deemed the proper avenue).

I've only come across it on the two cores, and I use many. For the longest it was just ppsspp but at some point threaded rendering became the default as you say, and thats when this cropped up.

my pc is certainly retroarch overkill, but i dont like the idea of leaving performance on the table lol. I suppose ill look at what ppsspp offers core options wise and make my determination there. If it has no similar option ill use the cfg override for now, easier to remember and un-do at some point in the future.

thanks again!