libretro / fuse-libretro

A port of the Fuse Unix Spectrum Emulator to libretro
GNU General Public License v3.0
36 stars 47 forks source link

Update to Fuse 1.6.0 and libspectrum 1.5.0 #89

Closed tomconte closed 3 years ago

leiradel commented 3 years ago

I'm quite sure this has been added in error: fuse/The Hobbit v1.2.tzx

lgtm-com[bot] commented 3 years ago

This pull request introduces 12 alerts and fixes 19 when merging 11422b1dea46ca9f88447a486b66ba8cc0b9b84c into 1bcb6ab1ce26ae9b86af07646e321c3eaec2dce2 - view on LGTM.com

new alerts:

fixed alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 12 alerts and fixes 19 when merging 74f7f0da9fe4a047d4e7e3fdc55fb463e4242d74 into 1bcb6ab1ce26ae9b86af07646e321c3eaec2dce2 - view on LGTM.com

new alerts:

fixed alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 12 alerts and fixes 19 when merging 29c8196039765a2a1a5da7b6eb4699f2c4172cf7 into 1bcb6ab1ce26ae9b86af07646e321c3eaec2dce2 - view on LGTM.com

new alerts:

fixed alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 12 alerts and fixes 19 when merging 3eca136251809ae21ff4c70965fbb608cf17aea0 into 1bcb6ab1ce26ae9b86af07646e321c3eaec2dce2 - view on LGTM.com

new alerts:

fixed alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 11 alerts and fixes 19 when merging bf87b391e1a1ca6adbef613214cd1aed12f9c411 into 1bcb6ab1ce26ae9b86af07646e321c3eaec2dce2 - view on LGTM.com

new alerts:

fixed alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 11 alerts and fixes 19 when merging ad00388ea926b6301efa9956eebf1013e773f254 into 1bcb6ab1ce26ae9b86af07646e321c3eaec2dce2 - view on LGTM.com

new alerts:

fixed alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 11 alerts and fixes 19 when merging 9fe23c4e5f22f785de8322225b48947a1ddce8d8 into 1bcb6ab1ce26ae9b86af07646e321c3eaec2dce2 - view on LGTM.com

new alerts:

fixed alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 11 alerts and fixes 19 when merging c47bb069faac87f3e11e2e7340fb352863e15c50 into 1bcb6ab1ce26ae9b86af07646e321c3eaec2dce2 - view on LGTM.com

new alerts:

fixed alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 11 alerts and fixes 19 when merging 91c20fab6ac0729b088c344797f34a2da8cb351f into 1bcb6ab1ce26ae9b86af07646e321c3eaec2dce2 - view on LGTM.com

new alerts:

fixed alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 11 alerts and fixes 19 when merging 0599e1e2b383dbb2531dd3e9eba81bdf4cbda1b7 into 1bcb6ab1ce26ae9b86af07646e321c3eaec2dce2 - view on LGTM.com

new alerts:

fixed alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 11 alerts and fixes 19 when merging 6bf5dbaf7fe7444051af4cbd34318341d6243a97 into 1bcb6ab1ce26ae9b86af07646e321c3eaec2dce2 - view on LGTM.com

new alerts:

fixed alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 11 alerts and fixes 19 when merging 9429c3ce5491c52c3945e12c0b15f895916b63db into 1bcb6ab1ce26ae9b86af07646e321c3eaec2dce2 - view on LGTM.com

new alerts:

fixed alerts:

tomconte commented 3 years ago

@leiradel @Gazdaman I think this PR is ready for review now... All checks pass and I have put in a workaround for the weird getopt_long crash on RPi. I have squashed all the changes and only kept separate commits for the changes I had to make to the Fuse code proper.

I will try to ping the Libretro Discord too!

tomconte commented 3 years ago

Ping @twinaphex ?

inactive123 commented 3 years ago

Honestly it's about time this core gets updated. So unless there are really serious reasons for not wanting to merge this, I'm inclined to just brute force this through.

inactive123 commented 3 years ago

Hi there @tomconte , please ping me on Discord. My name there is Autechre.

https://discordapp.com/invite/27Xxm2h

This PR currently fails for several platform targets and requires your attention. It'd be best if we just deal with this through real-time communication vs. Github.

I'll just post it here I guess in case you don't feel like going there -

PS Vita - https://git.libretro.com/libretro/fuse-libretro/-/jobs/256927 Nintendo 3DS - https://git.libretro.com/libretro/fuse-libretro/-/jobs/256921 Windows 32bit - https://git.libretro.com/libretro/fuse-libretro/-/jobs/256909 Windows 64bit - https://git.libretro.com/libretro/fuse-libretro/-/jobs/256908

The rest seems to build.

inactive123 commented 3 years ago

Reverting this for now because it takes some effort to fix these platforms again. @tomconte will be working in a branch on this revised version and then we can push a PR to master again once all platforms are building again.

snoofly commented 3 years ago

Any news on the Vita port? The retroarch nightly fuse builds for vita crash when trying to load a rom since the merge. I checked a fuse self from the 7th (1.1.1) and it works fine. Thanks