libretro / gambatte-libretro

Hard fork of Gambatte to the libretro API.
http://sourceforge.net/projects/gambatte/
GNU General Public License v2.0
105 stars 79 forks source link

[DRAFT] RS90 Support #191

Closed john-parton closed 3 years ago

john-parton commented 3 years ago

This PR adds support for the rs90. The device is extremely similar to gcw0.

The differences are:

Because of these changes, it needs to be recompiled.

PR to actually add support in RetroArch: https://github.com/libretro/RetroArch/pull/12592

Don't merge yet. There's compiler flags in there which should be removed, and broken white space.

inactive123 commented 3 years ago

Alright, looks fine to me. Is there any way you want to still improve this PR before we fasttrack this? Because it looks good to go for me.

john-parton commented 3 years ago

I'm going to push a slightly different version. I pass a bunch of redundant compiler flags, and there's some white space I messed up.

john-parton commented 3 years ago

@twinaphex Alright, I think it's ready. If it turns out there's performance issues with this core, specifically, I can try to tune the compiler flags, but any performance issues are more likely to be in the drivers.