search

libretro / gambatte-libretro

Hard fork of Gambatte to the libretro API.
http://sourceforge.net/projects/gambatte/
GNU General Public License v2.0
105 stars 79 forks source link

UWP compilation fix #215

Closed albertofustinoni closed 2 years ago

inactive123 commented 2 years ago

Wouldn't this break non-Windows RT platforms?

albertofustinoni commented 2 years ago

That condition is actually stricter then the previous one: it only triggers if the build is for UWP and if it uses C++/CX.

I'm changing this since the UWP VFS implementation is C++/CX: if the compiler does not support it (and Microsoft itself has deprectaed C++/CX for standard C++ via C++/WinRT) it at least can fall back to the generic stdio based implementation - which is better than nothing since at least it allows accesing files in the app installation folder.

inactive123 commented 2 years ago

OK, can you push a PR for this to retroarch too? Since that contains a snapshot of libretro-common.