search

libretro / gambatte-libretro

Hard fork of Gambatte to the libretro API.
http://sourceforge.net/projects/gambatte/
GNU General Public License v2.0
102 stars 78 forks source link

Palettes Updated! #229

Closed TheWolfBunny64 closed 1 year ago

TheWolfBunny64 commented 1 year ago

It's been quite a while since I've contributed to gambatte-libretro! What's changed, you might ask? These Game Boy palettes have been received an update!

Plus, palette 142 has received a name update! Goodbye, Pepsi Blue, hello, Pepsi-Cola Blue!

LibretroAdmin commented 1 year ago

Thanks for this.

DrUm78 commented 1 year ago

@TheWolfBunny64 @LibretroAdmin This PR makes the compilation fail for armv7 32-bit with the following error:


libgambatte/src/../libretro/gbcpalettes.h:2256:30: error: ‘twb64_142_pepsi_blue’ was not declared in this scope; did you mean ‘twb64_142_pepsi_cola_blue’?
 2256 |  { "TWB64 142 - Pepsi Blue", twb64_142_pepsi_blue },
      |                              ^~~~~~~~~~~~~~~~~~~~
      |                              twb64_142_pepsi_cola_blue
make: *** [Makefile.libretro:740: libgambatte/src/../libretro/libretro.o] Error 1```
TheWolfBunny64 commented 1 year ago

Yes. I apologize.

On Thu, Jul 14, 2022 at 7:39 AM DrUm78 @.***> wrote:

@TheWolfBunny64 https://github.com/TheWolfBunny64 This PR makes the compilation fail for armv7 32-bit with the following error:

libgambatte/src/../libretro/gbcpalettes.h:2256:30: error: ‘twb64_142_pepsi_blue’ was not declared in this scope; did you mean ‘twb64_142_pepsi_cola_blue’?

2256 | { "TWB64 142 - Pepsi Blue", twb64_142_pepsi_blue },

  |                              ^~~~~~~~~~~~~~~~~~~~

  |                              twb64_142_pepsi_cola_blue

make: *** [Makefile.libretro:740: libgambatte/src/../libretro/libretro.o] Error 1```

— Reply to this email directly, view it on GitHub https://github.com/libretro/gambatte-libretro/pull/229#issuecomment-1184530378, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUJRGQRP3YRGUPXHP3EIUSLVUARBRANCNFSM53QOYIJQ . You are receiving this because you were mentioned.Message ID: @.***>

TheWolfBunny64 commented 1 year ago

Thanks for this.

My pleasure!