libretro / gambatte-libretro

Hard fork of Gambatte to the libretro API.
http://sourceforge.net/projects/gambatte/
GNU General Public License v2.0
102 stars 78 forks source link

Halloween Treat: 100 New Palettes! #253

Closed TheWolfBunny64 closed 8 months ago

TheWolfBunny64 commented 8 months ago

Hey there, Gambatte-libretro community! It's been a while, hasn't it? Yep, I'm still alive! I brought a Halloween basket that's full of all treats, no tricks: 100 new Game Boy palettes! I even changed some Game Boy palettes in packs 1 and 2 altogether.

LibretroAdmin commented 8 months ago

Sorry for the long wait.

TheWolfBunny64 commented 8 months ago

Thank you! The Halloween treat might've been three days late, but it's still a treat nonetheless!

On Fri, Nov 3, 2023 at 7:07 AM LibretroAdmin @.***> wrote:

Merged #253 https://github.com/libretro/gambatte-libretro/pull/253 into master.

— Reply to this email directly, view it on GitHub https://github.com/libretro/gambatte-libretro/pull/253#event-10856558282, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUJRGQWCROVECARHCIR2DA3YCT3CBAVCNFSM6AAAAAA6F3GP7OVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQHA2TMNJVHAZDQMQ . You are receiving this because you authored the thread.Message ID: @.***>

Sanaki commented 8 months ago

I get a compilation error after this commit on x86_64 Linux. Any chance you could fix it up?

In file included from libgambatte/src/../libretro/libretro.cpp:9:
libgambatte/src/../libretro/gbcpalettes.h:2726:43: error: 'twb64_012_virtual_boy_ver' was not declared in this scope; did you mean 'twb64_012_virtual_vision'?
2726 |         { "TWB64 012 - Virtual Boy Ver.", twb64_012_virtual_boy_ver },
|                                           ^~~~~~~~~~~~~~~~~~~~~~~~~
|                                           twb64_012_virtual_vision
libgambatte/src/../libretro/gbcpalettes.h:2770:45: error: 'twb64_056_ticketmaster_azure' was not declared in this scope; did you mean 'twb64_054_game_master_ver'?
2770 |         { "TWB64 056 - Ticketmaster Azure", twb64_056_ticketmaster_azure },
|                                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
|                                             twb64_054_game_master_ver
libgambatte/src/../libretro/gbcpalettes.h:2856:42: error: 'twb64_142_pepsi_cola_blue' was not declared in this scope
2856 |         { "TWB64 142 - Pepsi Cola Blue", twb64_142_pepsi_cola_blue },
|                                          ^~~~~~~~~~~~~~~~~~~~~~~~~
libgambatte/src/../libretro/gbcpalettes.h:2874:36: error: 'twb64_160_g4_orange' was not declared in this scope; did you mean 'twb64_132_neon_orange'?
2874 |         { "TWB64 160 - G4 Orange", twb64_160_g4_orange },
|                                    ^~~~~~~~~~~~~~~~~~~
|                                    twb64_132_neon_orange
libgambatte/src/../libretro/gbcpalettes.h:2880:40: error: 'twb64_166_game_and_gold' was not declared in this scope; did you mean 'twb64_191_demons_gold'?
2880 |         { "TWB64 166 - Game and Gold", twb64_166_game_and_gold },
|                                        ^~~~~~~~~~~~~~~~~~~~~~~
|                                        twb64_191_demons_gold
libgambatte/src/../libretro/gbcpalettes.h:2897:40: error: 'twb64_183_doraemon_blue' was not declared in this scope; did you mean 'twb64_183_doraemon_tricolor'?
2897 |         { "TWB64 183 - Doraemon Blue", twb64_183_doraemon_blue },
|                                        ^~~~~~~~~~~~~~~~~~~~~~~
|                                        twb64_183_doraemon_tricolor
libgambatte/src/../libretro/gbcpalettes.h:2907:40: error: 'twb64_193_champion_blue' was not declared in this scope; did you mean 'twb64_193_champions_tunic'?
2907 |         { "TWB64 193 - Champion Blue", twb64_193_champion_blue },
|                                        ^~~~~~~~~~~~~~~~~~~~~~~
|                                        twb64_193_champions_tunic
libgambatte/src/../libretro/gbcpalettes.h:2909:43: error: 'twb64_195_evangelion_green' was not declared in this scope
2909 |         { "TWB64 195 - Evangelion Green", twb64_195_evangelion_green },
|                                           ^~~~~~~~~~~~~~~~~~~~~~~~~~
make: *** [Makefile.libretro:742: libgambatte/src/../libretro/libretro.o] Error 1
hizzlekizzle commented 8 months ago

I believe that's what GABO's PR here is intended to address: https://github.com/libretro/gambatte-libretro/pull/255

Sanaki commented 8 months ago

Ah, so it is. Didn't see that.