New Year's Pull Request

libretro / gambatte-libretro

Hard fork of Gambatte to the libretro API.

http://sourceforge.net/projects/gambatte/

GNU General Public License v2.0

102 stars 78 forks source link

New Year's Pull Request #259

Closed TheWolfBunny64 closed 5 months ago

TheWolfBunny64 commented 6 months ago

2024 marks my 5th year of being part of the Game Boy palette community, so to everyone who's been currently using my Game Boy palettes for your portable adventures on the Miyoo Mini, or the Miyoo Mini Plus, thank you all so much!

2024 also chiefly marks the 35th anniversary of the Game Boy! So I can't help but honor this milestone with an all-new update for the gambatte-libretro emulator!

Brighter shades for almost all of my palettes made possible with color-hex!
53 all-new palette makeovers! Most of the 53 palettes that have been changed as of this pull request are now multi-colored. Some are now two-toned!

Brace yourself for the next level of Game Boy palette goodness!

LibretroAdmin commented 6 months ago

Hi @bslenul , can you confirm if this can be merged? Thanks.

TheWolfBunny64 commented 6 months ago

In the words of Emperor Palpatine: DO IT!!!!!

On Fri, Jan 12, 2024, 06:01 LibretroAdmin @.***> wrote:

Hi @bslenul https://github.com/bslenul , can you confirm if this can be merged? Thanks.

— Reply to this email directly, view it on GitHub https://github.com/libretro/gambatte-libretro/pull/259#issuecomment-1889287964, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUJRGQW3V6ZKFMJXQ52P443YOE65LAVCNFSM6AAAAABA7DAIY6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBZGI4DOOJWGQ . You are receiving this because you authored the thread.Message ID: @.***>

LibretroAdmin commented 5 months ago

OK, this PR broke the builds again.

libgambatte/src/../libretro/gbcpalettes.h:2935:42: error: 'twb64_221_animate_blue' was not declared in this scope; did you mean 'twb64_026_animax_blue'? 2935 | { "TWB64 221 - Winter Icy Blue", twb64_221_animate_blue }, | ^~~~~~ | twb64_026_animax_blue

Please learn from this experience @TheWolfBunny64 for your next PRs, you need to make sure that the function that is referenced in gbcpalettes.h still exists and if not, update it accordingly.

LibretroAdmin commented 5 months ago

Pushed a buildfix - https://github.com/libretro/gambatte-libretro/commit/f3eb1e0542cec297d8f3a70daa935c2cd8f62208

So to clarify @TheWolfBunny64 , the mistake you made was updating the array name but then not updating the name in gbcpalettes.h. So next time you need to doublecheck that.