search

libretro / gambatte-libretro

Hard fork of Gambatte to the libretro API.
http://sourceforge.net/projects/gambatte/
GNU General Public License v2.0
102 stars 78 forks source link

Enable netlink on windows #265

Open samrussell opened 4 months ago

samrussell commented 4 months ago

Fixes #201

Add WSAStartup call and wrap ioctl and close calls with their win32 equivalents. Minimal logging to check for initial socket() failure.

Tested on win10 x64 and win11 x64 with retroarch

LibretroAdmin commented 4 months ago

Hi, ideally we make this work for the Mingw build too instead of just MSVC.

samrussell commented 4 months ago

Does my change break anything in the mingw build or does it just not improve it?

If it doesn't make anything worse and it does make some things better then would you be happy to accept the PR?

LibretroAdmin commented 4 months ago

Is it not possible for you to see if you can get this to compile for the regular Windows build too?

Also, if I may ask, what is the current state of this on Linux? So from what I understand for Linux netplay is already enabled and it's just not enabled for the Windows builds yet?

samrussell commented 4 months ago

Also, if I may ask, what is the current state of this on Linux?

How exactly would I know this?

Is it not possible for you to see if you can get this to compile for the regular Windows build too?

It's entirely possible, I'm just not going to do it. I found a bug for my platform, wrote and tested a fix, and I'm offering it to you as a courtesy. If you want to merge it then you can. If you don't want to merge it then don't.