libretro / gambatte-libretro

Hard fork of Gambatte to the libretro API.
http://sourceforge.net/projects/gambatte/
GNU General Public License v2.0
104 stars 78 forks source link

Super Game Boy palette/border support? #79

Open bryc opened 7 years ago

bryc commented 7 years ago

A number of GBx emulators support basic features of the SGB like custom palettes and borders. To name a few, VBA-M, KiGB, bgb, Gameyob (DS) and Lameboy (DS). Unfortunately the VBA-M libretro ports are GBA-only and don't seem to have any plans to support classic GBx, which is a shame. In fact there are no libretro cores that have this feature.

I honestly just want the custom palettes - Lots of DMG games have special palettes for SGB that add nicer colors than just B&W, such as Kirby 2 and Pokemon Blue.

Could it be possible to support those SGB color modes for games that use it? Would it be accepted as a PR? Or would this functionality be better set in a hypothetical VBAM-GBC core. The GB experience just isn't complete without it.

What do you think?

Here is a comparison:

image

Left: Kirby 2 using GBC palette Right: Kirby 2 using SGB palette

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/42468932-super-game-boy-palette-border-support?utm_campaign=plugin&utm_content=tracker%2F1258974&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1258974&utm_medium=issues&utm_source=github).
hizzlekizzle commented 7 years ago

Yeah, SGB palettes would be great, and we would likely accept non-hacky PRs to VBAM, beetle-gba or Gambatte that provided it. Currently, the only way to get SGB functionality is via bsnes, but it's weird, only works through the command line and is broken everywhere but Windows for some unknown reason.

sergiobenrocha2 commented 7 years ago

This issue was moved to libretro/libretro-meta#49

SuperMeatBro commented 7 years ago

But would it be possible to implement?

paradadf commented 5 years ago

@bryc I believe, after https://github.com/libretro/gambatte-libretro/pull/113 this issue can be closed.

bryc commented 5 years ago

@paradadf #113 is not the same thing. Those are just SGB palette templates, not the game-controlled palettes.

When switching to 'sgb' setting, I don't get the 3 colors in the intro, I just get this:

image

paradadf commented 5 years ago

@bryc ok, then @hizzlekizzle should re-open the issue. Sorry about the misunderstanding.

Cee123 commented 5 years ago

I noticed exactly the same thing the other day. The colours are NOT the accurate colouring of Super Game Boy enhanced games (such as Pokemon Red/Blue) and will only display in one colour. There are also no support for Super Game Boy borders. I guess our only alternative if we want these features, is to use mGBA until someone decides to actually implement these in Gambatte.

By comparison, here is Pokemon Blue on Gambatte 60534018-80b8d300-9d33-11e9-8e61-bbfeed2945cc

And this is Pokemon Blue on mGBA (how it's supposed to look) 60534047-8e6e5880-9d33-11e9-9060-1c5fbcc8e9e7

The second screenshot is how it also displays on the Gameboy Color.

Cee123 commented 5 years ago

Guys, I added a bounty for SGB features to be added, if anyone is interested. https://www.bountysource.com/issues/76534488-incorrect-coloring-on-super-gameboy-enhanced-games-and-super-gameboy-borders

pressRtowin commented 1 year ago

Wew this is still open