[VITA] Golden Sun issues

[Zarke669]

graphical error in game intro and normal attack sound seems too low.

[hugogacia360]

On PS2 this game crashes and feeze after some minutes playing it

[Darkstalix]

There are a lot of sound issues and it feels like they happen because too many sounds are supposed to happen at the same time on impact and its like a sound channel missing or smth. -Normal Attack sound is missing or waay too low -Odyssey/Liquifier/Megiddo/summons have a lot of slowdowns

[DrUm78]

Hardware: FunKey S device (armv7 32-bit) with 64MB RAM Software: PicoArch frontend OS: Custom Linux 4.14.14 Commit: https://github.com/libretro/gpsp/commit/2d28451f6cb74eed09203b4b3a2da3549dd27cc9

Same issues happen on classic_armv7_a7 fyi.

[andymcca]

Sound issue is actually the noise channel missing - I did a couple of PRs based on the TempGBA code to try and fix but these aren't quite right either, so have agreed with David to close these whilst he takes time to develop a proper fix. If you are impatient and happy to mess about with your own build, you can try applying the code in PR #203 which you should find brings the battle sounds back (albeit definitely not 100% accurate!).

The slowdowns are likely due to self-modifying code hammering the recompiler - have also been chatting with David about this recently and he has some ideas on implementing some measures to handle this better (same as TempGBA/ReGBA).

[andymcca]

Graphics issues on intro are down to broken OBJ transparency implementation. Long explanation in issue #74.

[andymcca]

Attack sound is fixed in the most recent commit 1d972ec !

[DrUm78]

I confirmed that the attack sounds are now fixed in GS 1 & 2, thanks! 👍

[davidgfnet]

As mentioned in https://github.com/libretro/gpsp/issues/74 the GFX effects are fixed. The sound (noise channel) is also fixed, even tho there's still a few small bugs there which I will fix in an upcoming PR. Let's close this. Feel free to open an issue if any other issue is still present.

[DrUm78]

The graphical glitch seems to be fixed now indeed, thanks! 🙏

[Darkstalix]

Graphical and sound issues fixed ty so much please try if its possible for Boreas summon screen gets black and you can only see the battle log below

[andymcca]

@Darkstalix please provide a save file or better still a save state so we can try and reproduce the black screen issue

[Darkstalix]

@Darkstalix please provide a save file or better still a save state so we can try and reproduce the black screen issue I wanted to mention that it happens in VITA and even windows retroarch builds Hey thanks for attempting this it happens to both golden sun 1 and 2 Both my roms and saves are from my original carts from EU region( i cant recall if there was a region compatibility for saves) Golden sun states and saves.zip

[andymcca]

@davidgfnet may be worth reopening this or moving to a new issue. From the above, this is on the latest commit. albeit a very specific point in the game - I'm happy to do some testing with the previous renderer etc to see if this has always been the case.

[Darkstalix]

its not a specific point in game in terms of story place etc. just using the Boreas summon this happens, you get a black screen till the end of the summon cutscene

[andymcca]

@Darkstalix got it, thanks for the clarification.

[davidgfnet]

You are right sir, it seems there's a bug in the windowing horizontal limit logic. I fixed this in my fork (https://github.com/davidgfnet/gpsp/commit/1d46986e928c927ef42bbe2a20f10ed21b1bd2c5). I will merge this in the upcoming days, stay tuned.

[Burlz10]

Hi, I started a new ticket for this without realizing this issue was already being covered. If additional save states or save files are needed for testing please let me know. In addition I noticed a graphical glitch in which background elements end up in the foreground. Should this become its own ticket? Thanks.

[andymcca]

Please start a new issue for the carpet glitch as this is separate to the above. Also please reference the same issue in mgba which was identified and closed a few years ago - https://github.com/mgba-emu/mgba/issues/1444

[Burlz10]

Thank you. New ticket was started