libretro / gpsp

gpSP for libretro.
GNU General Public License v2.0
51 stars 51 forks source link

Added Goodboy Galaxy rumble support #233

Closed Ninoh-FOX closed 4 days ago

davidgfnet commented 6 months ago

Hey! You have a few more changes there. Is that intentional?

Ninoh-FOX commented 6 months ago

Yes, it is the compilation method for the Miyoo mini consoles and the pkmn pinball database in case Gameboy Player is ever supported. It does not affect the rest of the code.

davidgfnet commented 6 months ago

Again, the pokemon pinball game does not use GPIO3 rumble, so it is incorrect to set FLAGS_RUMBLE to it. Only patched games can work with that configuration, are you using some IPS patch? The right way to do it, would be to implement GameBoy Player rumble support, which will come in the near future. Thanks!

Ninoh-FOX commented 6 months ago

Well, the Goodboy Galaxy work (I know that Pkmn P not work for now)

Ninoh-FOX commented 6 months ago

Putout pkmn rumble flag