search

libretro / gpsp

gpSP for libretro.
GNU General Public License v2.0
52 stars 52 forks source link

Add support for RetroArch cheats. #237

Closed rohit-n closed 8 months ago

spaceboydavey commented 8 months ago

Does this add support for encrypted cheat types? I'm so annoyed by GPSP not supporting encrypted cheats. If so can we please speed up merging this?

rohit-n commented 8 months ago

I doubt it, but I haven't tried any encrypted cheats. I've only tested this change for searching for cheats in RetroArch's interface.

hizzlekizzle commented 8 months ago

@davidgfnet do you have any opinions on this one?

davidgfnet commented 8 months ago

gpsp has already support for cheat codes, what does this add exactly? Would be nice to have more info :P

rohit-n commented 8 months ago

This commit allows the user to create cheat codes by scanning memory addresses in the RetroArch Quick menu interface. Without this commit, the "Start or Restart Cheat Search" menu option does nothing.

Another benefit of this is that cheats created this way work for the mGBA core, and vice versa.

davidgfnet commented 8 months ago

Ah right, was not aware of those options. I'd still recommend using the gpsp cheats but it is indeed useful to be able to search for memory patterns to create new cheats and such. This was not possible previously but PR #117 fixed that (I assume that's why it never got implemented). Thanks for contributing this!