search

libretro / libretro-atari800

atari800 3.1.0 for libretro/libco WIP
17 stars 45 forks source link

Add car, com and xex to valid extensions #61

Closed HiassofT closed 3 years ago

HiassofT commented 3 years ago

CAR is the standard format/extension for Atari cartridge dumps - see also atari800/DOC/cart.txt

COM is the standard extension for Atari computer binary (compound) files, XEX is widely used on DOS/Windows systems instead so the files can be distinguished from native DOS/Windows COM files.

Sanaki commented 3 years ago

Have you verified car and com files work in the core? I know xex is already in the info file, which is actually how I found this issue. I was coming to add it here myself, so you saved me a step.

raphkoster commented 3 years ago

I am pretty sure .car does, it's been supported in the non-Libretro version since forever.

The docs have the following as supported in the core:

.7z .a52 .atr .bas .bin .car .dcm .xex .xfd .zip .atr.gz .xfd.gz

HiassofT commented 3 years ago

Yes, I've been using car and com with official atari800 for ages. And I also tested this with the kodi retroplayer addon (which uses libretro-atari800 8ce851fbca0d360763a267322f6a76c3c80ddae6) and it worked fine, too.

Sanaki commented 3 years ago

You'll need to add car and com to this file as well for it to be supported in retroarch (xex is already there): https://github.com/libretro/libretro-super/blob/master/dist/info/atari800_libretro.info

HiassofT commented 3 years ago

shouldn't the info in libretro-super be auto-generated from the infos in the core file? Currently they disagree, xex is listed in libretro-super, but not in the emulator core (which is queried eg by kodi's scripts to know the list of supported extensions) - and the order of extensions in libretro-super is different, too

Sanaki commented 3 years ago

Info files are not auto-generated. It's possible some things like extensions could be auto-updated, but the bulk of that info isn't present to be pulled from the core itself.

HiassofT commented 3 years ago

thanks for the info, I can create a PR to sync extensions in libretro-super with the core (probably best after this PR has merged then I can reference the core commithash in the PR)

HiassofT commented 3 years ago

libretro-super PR is here: https://github.com/libretro/libretro-super/pull/1487