search

libretro / libretro-cap32

caprice32 4.2.0 libretro
21 stars 34 forks source link

Border crop option issues #138

Closed Vweber73 closed 8 months ago

Vweber73 commented 9 months ago

Hi, The new border crop option is nice! But 2 issues: -when you toggle it, the change is not reflected, even after core restart. You have to close and open again. -the virtual keyboard is also cropped!

Cheers

DSkywalk commented 9 months ago

-when you toggle it, the change is not reflected, even after core restart. You have to close and open again.

At the moment, yup is a mandatory. And I prefer it that way, it's not something you're changing all the time, it was originally going to be a compile-time feature only.

-the virtual keyboard is also cropped!

In the similar way, the on-screen keyboard was going to be removed for this feature, but I preferred to leave it to be able to press some occasional key. We will have to redo the keyboard or make two versions, one trimmed and one full screen. The truth is that I prefer to simplify and have a new version a little more reduced.

These will be things to improve for next year, I hope you continue to enjoy the emulator! thx :)

Vweber73 commented 9 months ago

Many thanks! I fully understand. But please don't reduce the keyboard, it has to be usable on my Z fold 3, using all available width, even when the border is not cropped! :) Cheers

Vweber73 commented 8 months ago

Just one more thing: in border crop mode, not only the virtual keyboard is also cropped, but it is also completely unusable: the key presses don't match the right key, the mapping is totally wrong, as if the normal keyboard was still the base for the key presses...

Cheers

DSkywalk commented 8 months ago

I think was fixed some days ago, please update your core 👍

El jue., 21 dic. 2023 18:01, Vweber73 @.***> escribió:

Just one more thing: in border crop mode, not only the virtual keyboard is also cropped, but it is also completely unusable: the key presses don't match the right key, the mapping is totally wrong, as if the normal keyboard was still the base for the key presses...

Cheers

— Reply to this email directly, view it on GitHub https://github.com/libretro/libretro-cap32/issues/138#issuecomment-1866650698, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEIZNVFKSFUIPPDN6DMJRDYKRTPPAVCNFSM6AAAAABA27C3E6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRWGY2TANRZHA . You are receiving this because you modified the open/close state.Message ID: @.***>

Vweber73 commented 8 months ago

I have fd60b77, which I believe is the latest, yet I have this problem...

Vweber73 commented 8 months ago

Many thanks! The mouse is correct now. Too bad the first and last column of keys are unreachable. Hope this can be fixed, I love this border crop mode and would like to stick to it :)

DSkywalk commented 8 months ago

"don't reduce the keyboard" and you also say "last column of keys are unreachable"

I will try to find the best solution but something will have to be reduced, because there is no magic ;-)

Merry Christmast and enjoy! :christmas_tree: :sparkles:

Vweber73 commented 8 months ago

Sorry I was unclear, when I said "don't reduce the keyboard" I meant "don't make it smaller in normal mode" and "please make it smaller (than currently) in border crop mode". I, short I meant that the keyboard should be the same and use 100% of the width, without being cut, whatever the mode is! 🙂

Man thanks for your kind wishes, merry Christmas to you too! 🙂