3DS compilation fails - Githubissues

libretro / libretro-cap32

caprice32 4.2.0 libretro

21 stars 34 forks source link

3DS compilation fails #50

Closed inactive123 closed 5 years ago

inactive123 commented 5 years ago

http://p.0bl.net/93564

Let me know when the issues are fixed and I'll enable the core again on the buildbot.

DSkywalk commented 5 years ago

@twinaphex is affected by the same problem, nuklear (check issue #51)

r-type commented 5 years ago

it just failed because app.c:(.text+0x28568): undefined reference to getuid' app.c:(.text+0x2856c): undefined reference togetpwuid'

https://github.com/libretro/libretro-cap32/blob/bbd1f6b9765ae032e698c06902b3762c11c28954/libretro/nukleargui/filebrowser.c#L163

same as for the wii, just deal with an #ifdef

DSkywalk commented 5 years ago

imagen

My question: Is it necessary to have a filemanager/explorer to load a disk using a lowres GUI? Now that we have the new disk-control manager, people could use this or use load content as usually.

imagen

That file loader also avoids all launcher file-loader-code (*) and I think it isn't the job of a core and is not a good idea.

Thanks! :+1: (*) launcher also unzips the roms, also we could remove libz core dependency...

r-type commented 5 years ago

I think its good idea to leave it in code, as i wrote the code and it is usefull for me and i use it. Btw no cost for you to leave it as you dont have to maintin it.

Also, evry time, they want to remove ingame gui in core,but if i had listen them, they will probably also remove the mame ingame osd:)

DSkywalk commented 5 years ago

Well take a look... imagen imagen

The current code for the GUI is uncommented, it doesn't follow any consistent style or structure (what are those .i files?) and contains pieces without any functionality.

I don't understand your reply, we collaborate in an opensource project. It's not a matter of removing anybody's code but to improve what we currently have and give it a functionality that can be used by everyone. Maybe for a quick port it's useful but for a long term solution I really think that this part of the code can be improved.

I'm just trying to help.