search

libretro / libretro-cap32

caprice32 4.2.0 libretro
21 stars 36 forks source link

Disk autorun fails when keyboard is remaped (.rmp) #62

Closed nportillo2 closed 5 years ago

nportillo2 commented 5 years ago

Since new version disk autorun fails if a game has a mapped keyboard file (.rmp)

On screen you can see that autorun types som garbage characters like RUN"94102. instead of RUN"1942.BAS" so game fails to load.

Older versions works perfect. Very annoying since I mapped 200 games to play directly with a gamepad and now they are unusable.

Using emulationstation and retroarch combo windows and retropie.

DSkywalk commented 5 years ago

Please can you upload your rmp file and... what is your system locale?(language locale) what is the last version where autorun works?

thanks

nportillo2 commented 5 years ago

I'm using windows 10 with spanish language with i'm sure this problem has nothing to do with the OS since the same problem happens with retropie 4.4; on the raspberry everything works with the original downloaded retropie 4.4 image, but if you update the retroarch (and the cap32) the same error happens.

The system where autorun fails is 1.7.6 Cap32 4.5 6ca94b3 Using 1943 game as example, if I delete the 1943.rmp file and start the game without remapping file it autoloads the game succesfully with a RUN"1943. (but can not play since keys are not remapped to the gamepad). Once I'm in the game I can remap the keys.

But when I save the remapped keys from the menu (to 1943.rmp on config/remaps/cap32 folder) next time I try to autorun the disk autoload tries to run ru2943. and gets syntax error.

Not every game fails I would say 80%. It's easy to reproduce on almost every game.

I don't know how to upload any file here, but file "1943.rmp" is pretty clear and short, I copy and paste here:

input_player1_key_y = "121" input_player1_key_x = "110" input_libretro_device_p1 = "259" input_player1_analog_dpad_mode = "1" input_libretro_device_p2 = "259" input_player2_analog_dpad_mode = "0" input_libretro_device_p3 = "0" input_player3_analog_dpad_mode = "0" input_libretro_device_p4 = "1" input_player4_analog_dpad_mode = "0" input_libretro_device_p5 = "1" input_player5_analog_dpad_mode = "0" input_player1_key_start = "49" input_player1_key_b = "304"

The system working without autoloading issues is retroarch 1.7.3 with cap32 4.2.

Thank you for your time!

DSkywalk commented 5 years ago

The problem is that keyboard_cb get false "release key" events, when amstrad_keyboard is selected on controls menu. I think is a core problem, but i try to investigate. My last commit fixes the problem temporarily.

Code: https://github.com/libretro/libretro-cap32/blob/4e7a1a48b046a0a463a44d41fd584760381dcf58/libretro/retro_events.c#L394

I do not press/released any button or key and I get:

Down: no, Code: 49, Char: 0, Mod: 0.
Down: no, Code: 110, Char: 0, Mod: 0.
Down: no, Code: 304, Char: 0, Mod: 0.
Down: no, Code: 121, Char: 0, Mod: 0.
Down: no, Code: 49, Char: 0, Mod: 0.
Down: no, Code: 110, Char: 0, Mod: 0.
...
nportillo2 commented 5 years ago

Is there any way get a windows cap32_libretro.dll to test the fix?

DSkywalk commented 5 years ago

sure, just update your core using retroarch.

nportillo2 commented 5 years ago

I can confirm it works, but now there is another issue, I open a new different ticket.