Closed SpriteOvO closed 2 years ago
Unfortunately I have to revert this, this broke all RetroArch builds. Please be more careful in the future when making these changes.
https://github.com/libretro/RetroArch/commit/6b9a382f2e90923b38fcca1f5a0d11ffe391e3fe
You can see the build failures here.
Send these libretro-common PRs to RetroArch next time, at least there are CI jobs there that can detect build failures for all the platforms we support.
You can see the build failures here.
Send these libretro-common PRs to RetroArch next time, at least there are CI jobs there that can detect build failures for all the platforms we support.
Sorry this broke the build, I'll try to fix it later and reopen a PR over there.
I'm compiling a project for RISC-V 64-bit that depends on
libretro-common
, and I got errors:It indicates that it is incorrectly entering an ARM specific code path.
This PR changed the macro condition of ARM specific code from
!defined(CPU_X86)
todefined(CPU_ARM)
to support it compiling for more other architectures.The ARM detection code is referenced from https://github.com/boostorg/predef/blob/499d28e34f78950ede62fdb9b74cbe06eb5fdf96/include/boost/predef/architecture/arm.h#L73-L83.