search

libretro / libretro-database

Repository containing cheatcode files, content data files, etc.
Creative Commons Attribution Share Alike 4.0 International
930 stars 790 forks source link

[BUG] Scan directory detecting backup as wrong game #1444

Open enzideout opened 7 months ago

enzideout commented 7 months ago

Whenever I try to scan my backup of Phantasy Star Online (USA) for Sega Dreamcast, it is detected as Sonic Adventure 2: The Trial. I've verified my backup against redump, so I know the backup is good. Whenever I load it, RetroAchievements sees it as Phantasy Star Online. I've tried it as a gdi/bin and chd. I tried loading a backup of Sonic Adventure 2: The Trial (also verified against redump) and it didn't detect it. I've tried updating the RDB files, but no change. This is on Versions 1.16.0 and 1.17.0. I wasn't sure if there was a simple issue with the RDB file since Sonic Adventure 2: The Trial was released with PSO.

Thanks!

image

hizzlekizzle commented 7 months ago

This may be an issue for the database repo: https://github.com/libretro/libretro-database/

we'll see what @RobLoach thinks.

RobLoach commented 7 months ago

Looks like they're both listed with the same serial....

game (
    name "Sonic Adventure 2 - The Trial (USA, Japan) (En,Ja)"
    description "Sonic Adventure 2 - The Trial (USA, Japan) (En,Ja)"
    serial "51100"
    rom ( name "Sonic Adventure 2 - The Trial (USA, Japan) (En,Ja) (Track 3).bin" size 1185760800 crc 6499E0B7 md5 B26C2DF025A5D749A267E93E5554ED78 sha1 79389E07BCBA68E5E6E4D37C04EA271D67DFE3E9 serial "51100" )
)
game (
    name "Phantasy Star Online (USA) (En,Ja,Fr,De,Es) (Rev B)"
    description "Phantasy Star Online (USA) (En,Ja,Fr,De,Es) (Rev B)"
    region "USA"
    serial "51100"
    rom ( name "Phantasy Star Online (USA) (En,Ja,Fr,De,Es) (Rev B) (Track 3).bin" size 1185760800 crc 6F65A922 md5 6BA51DA93F90B65357AA36D1D02D6C1D sha1 6A61981059F18982285EDB9C8E21AE0557B7935F serial "51100" )
)

http://redump.org/disc/5990/

i30817 commented 4 months ago

It's possible it's not wrong.

I remember a worse case, I saw (threads of fate USA and urban chaos USA iirc) where serials are supposed to be different in redump, when they're actually equal in the discs, because Sony screwed up and instead of owning it, they lied about it in all listings. I can tell because I have the iso and the serial that is supposed to be there isn't if I scan the disc in a hex editor but the checksum is the same as the one in redump...

So redump has a checksum for threads of fate (I think) that scans as 'urban chaos' in the serial scanner (the only way to avoid it is the manual scanner because the normal scanner doesnt use checksums for ps1 anymore).

The difference between those serials is one digit and obviously some Sony USA employee fatfingered it and forgot all about it and there were no sanity checks.