Arcade dats don't show that parent roms also need samples

paradadf commented 7 years ago

I noticed the following with fbalpha dats but it applies to all arcade dats. Reference: https://github.com/libretro/fbalpha/issues/105#issuecomment-271067873 I noticed it with cheekyms, as the game has no clones and the fact that the game needs samples wasn't marked, as its sample isn't being mentioned in the header:

<game name="cheekyms">
        <description>Cheeky Mouse</description>
        <year>1980</year>
        <manufacturer>Universal</manufacturer>
        <rom name="cm03.c5" size="2048" crc="1ad0cb40"/>
        <rom name="cm04.c6" size="2048" crc="2238f607"/>
        <rom name="cm05.c7" size="2048" crc="4169eba8"/>
        <rom name="cm06.c8" size="2048" crc="7031660c"/>
        <rom name="cm01.c1" size="2048" crc="26f73bd7"/>
        <rom name="cm02.c2" size="2048" crc="885887c3"/>
        <rom name="cm07.n5" size="2048" crc="2738c88d"/>
        <rom name="cm08.n6" size="2048" crc="b3fbd4ac"/>
        <rom name="cm.m9" size="32" crc="db9c59a5"/>
        <rom name="cm.m8" size="32" crc="2386bc68"/>
        <rom name="cm.p3" size="32" crc="6ac41516"/>
        <sample name="squeek" />
        <sample name="hammer" />
        <sample name="sqeekdead" />
        <sample name="two" />
        <sample name="squeek2" />
    </game>

Samples of parent roms should be mentioned as well like this: <game name="cheekyms" sampleof="cheekyms">

RobLoach commented 7 years ago

I think samples need to be in the system/fba folder. I could be wrong, however.

paradadf commented 7 years ago

@RobLoach that's not what this issue is about. It's about samples not being shown as needed by certain roms on the dat file.

RobLoach commented 7 years ago

Ah, gotcha. :+1:

libretro / libretro-database

Arcade dats don't show that parent roms also need samples #381