search

libretro / libretro-database

Repository containing cheatcode files, content data files, etc.
MIT License
872 stars 782 forks source link

PSX Gokujou Parodius Da! Deluxe Pack cannot be identified by database #905

Open RobLoach opened 5 years ago

RobLoach commented 5 years ago

Submitted by @devcen

Description

Gokujou Parodius Da! Deluxe Pack (crc: 9c787b3f) cannot be identified by the database. Not that the serial is wrong (SLPS-00002), looking at the source code of task_database_cue.c, it is looking for a string "boot", but this iso does not have that.

Expected behavior

The clean dump is identified in the psx database.

Actual behavior

Not listed in playlist.

Steps to reproduce the bug

  1. Prepare clean dump crc 9c787b3f
  2. Prepare Sony Playstation database
  3. Use scan file or scan directory
  4. Check if it shows on the list [FAILED]

Version/Commit

You can find this information under Information/System Information

Environment information

RobLoach commented 5 years ago

@devcen This one?

https://github.com/libretro/libretro-database/blob/d891a0d6da6e87b60a36db4acd28b0e3f41b3317/metadat/libretro-dats/Sega%20-%20Saturn.dat#L962-L966

game (
    name "Gokujou Parodius-Da! Deluxe Pack v1.001 (Konami) (Japan)[compilation]"
    description "Gokujou Parodius-Da! Deluxe Pack v1.001 (Konami) (Japan)[compilation]"
    rom ( name "Gokujou Parodius-Da! Deluxe Pack v1.001 (1995)(Konami)(NTSC)(JP)(Track 1 of 3)[!][compilation].iso" size 450488320 crc 259aa2ee md5 6a026d9ba746f45b2f84a1dcced40995 sha1 d012ea0993f9253630ce2a996c764ba8da2d61ff )
)

What system?

RobLoach commented 5 years ago

Can you find it on Redump?

DevCeN commented 5 years ago

Its the PSX one not the Saturn one. Here http://redump.org/disc/5337/

RobLoach commented 5 years ago

This is from @orbea

So I looked again and this is what I see.

$ grep --exclude-dir=.git -r SLPS-00002
dat/Sony - PlayStation.dat: serial "SLPS-00002"
dat/Sony - PlayStation.dat:     serial "SLPS-00002"
dat/ps1.idlst:SLPS-00002 "Gokujou Parodius Deluxe Pack"
Binary file rdb/Sony - PlayStation.rdb matches

In dat/Sony - PlayStation.dat.

game (
        name "Gokujou Parodius Da! Deluxe Pack (Japan)"
        serial "SLPS-00002"
        description "This compilation collects the first two arcade incarnations of Konami's shoot'em'up parody series on one disc: Parodius Da! and Gokujyou Parodius."
        developer "Konami Computer Entertainment Tokyo, Inc"
        publisher "Konami"
        releaseyear "1994"
        releasemonth "12"
        releaseday "3"
        users "2"
        genre "Shooter"
        rom (
                serial "SLPS-00002"
                image "Gokujou Parodius Da! Deluxe Pack (Japan).cue"
        )
)

In rdb/Sony - PlayStation.rdb.

SLPS-00002<A6>serial<C4>
SLPS-00002<8A><A4>name<B7>Goiken Muyou II (Japan)<AB>descriptionٗGoiken Muyou 2 is a 3d fighting game that features 10 characters (male & female ones) and different game modes (story mode, arcade, vs, tag team, etc).<A5>genre<A8>Fighting<A5>users<CC>^B<AC>releasemonth<CC>
$ grep -r 'Gokujou Parodius Da! Deluxe Pack' rdb/
Binary file rdb/Sega - Saturn.rdb matches
Binary file rdb/Sony - PlayStation.rdb matches
SLPM-87329<A6>serial<C4>
SLPM-87329<8A><A4>name<D9>(Gokujou Parodius Da! Deluxe Pack (Japan)<AB>descriptionْThis compilation collects the first two arcade incarnations of Konami's shoot'em'up parody series on one disc: Parodius Da! and Gokujyou Parodius.<A5>genre<A7>Shooter<A5>users<CC>^B<AC>releasemonth<CC>^L<AB>releaseyear<CD>^Gʩdeveloper<D9>(Konami Computer Entertainment Tokyo, Inc<A9>publisher<A6>Konami<A6>serial<C4>

I think SLPS-00002 is associated with the wrong game and this is a database issue.