search

libretro / libretro-database

Repository containing cheatcode files, content data files, etc.
Creative Commons Attribution Share Alike 4.0 International
930 stars 790 forks source link

Update Headered Nintendo - NES.dat #907

Open ZoneOut19090 opened 5 years ago

ZoneOut19090 commented 5 years ago

When scanning files for RetroArch for Nintendo - NES the rom Super Mario Bros. 2 (USA0 (Rev A) does not show up. The file is from the No-Intro set. It appears the crc number is different in the database versus the rom.

RobLoach commented 5 years ago

Right... The No-Intro NES entries have headers removed, and the libretro headered DAT hasn't been updated in a long time: https://github.com/libretro/libretro-database/blob/master/dat/Nintendo%20-%20Nintendo%20Entertainment%20System.dat

Would you be willing to re-create it? Can use CLRMAMEPRO's Dir2Dat to build it.

ghost commented 5 years ago

nointro NES dat does not have headers removed. headers are just ignored during verification since only prg+chr checksums are computed. headers are still a necessity in nes roms.

Sanaki commented 4 years ago

I just downloaded the latest dat and verified this, the no-intro dat does indeed have the headers removed. It's distributed with a header-skipping file to allow matching to the headerless dat. Removing the first 16 bytes from headered NES files will result in a direct match without using the header skipper. Perhaps the better solution here is to have retroarch add support for the skip format. That would solve a number of problems at once, and would further improve matching for 7800, Lynx, and FDS.