Remove audio env cb - Githubissues

libretro / libretro-lutro

An experimental lua game framework for libretro following the LÖVE API

https://lutro.libretro.com

MIT License

149 stars 46 forks source link

Remove audio env cb #200

Closed kivutar closed 3 years ago

kivutar commented 3 years ago

Because RA runs this callback on a separate thread and it causes crashes.

RobLoach commented 3 years ago

Getting a segfault when running tests/audio/main.lua

kivutar commented 3 years ago

Yeah I can reproduce the segfault, even in ludo

lgtm-com[bot] commented 3 years ago

This pull request fixes 1 alert when merging f7f9b17055727f916a35f130726c1419fa9f6354 into d74075d1608746d36927082e804336f8cfb34592 - view on LGTM.com

fixed alerts:

1 for Local variable hides global variable

kivutar commented 3 years ago

@jstine35 @RobLoach I'm going to merge this anyway because I understand what this segfault is about, it will only happen when a resource is missing, so it shouldn't happen on well maintained games.

I suppose checking if fixes exist and exiting properly will have to be added back. This can be done in another PR.

It's more important to get Lutro games to run on RA first. And this PR does that.