search

libretro / libretro-pocketcdg

PocketCDG libretro port
http://www.kyuran.be
MIT License
5 stars 12 forks source link

Use proper VFS version #23

Closed mudlord closed 1 year ago

LibretroAdmin commented 1 year ago

What justifies its use? Is there a function it needs that VFS v1 doesn't provide?

mudlord commented 1 year ago

https://github.com/libretro/libretro-pocketcdg/blob/master/libretro-common/streams/file_stream.c#L67

Exact same problem as many other cores which I have fixed, or am now being ignored (which I don't really care, not really fussed😀 ). That implementation includes a func ptr for vfs_truncate, which is in the V2 specs. Just like the other cores.

The filestream interface in other cores requires version 2. Looking at the above code, seems the exact same version of libretro-common as other cores for file_stream VFS interfaces.

Use case is simple: it fixes VFS for frontends that do support VFS interfaces (mine does now, as well as RetroArch, instead of relying on libretro-common code). Hence the motivation for all the fixes lately.