search

libretro / libretro-super

Super repo for other libretro projects. Fetches, builds and installs.
MIT License
409 stars 284 forks source link

Building libretro-mpv core #691

Open ofry opened 6 years ago

ofry commented 6 years ago

https://github.com/libretro/libretro-mpv

orbea commented 6 years ago

@ofry I have a hard time seeing how the mpv core will ever work for the buildbot.

There are at least three big inherent issues with mpv concerning portable builds.

  1. The user will need a local copy of libmpv, not all operating systems provide this.
  2. The user will need a local copy of of the mpv ffmpeg rage fork or the ffmpeg git master, neither are trivial to get and most operating systems provide neither. It does not seem likely mpv upstream will officially support any ffmpeg releases again.
  3. RetroArch will need to be built without ffmpeg support which will break the already existing video player.
ofry commented 6 years ago

1)2) at least for windows? Or to consoles with static linking all bundle? 3) replace existing video player to mpv?

orbea commented 6 years ago

I've no idea how you would statically link libmpv and ffmpeg to windows binaries. If someone else wants to figure that out that they can, but somehow I suspect it will be an exercise in frustration and futility.

There are significant technical and political issues with mpv and I do not think its a good fit as the default RetroArch video player, but I'd rather not go in depth on this topic here...

orbea commented 6 years ago

I'm not trying to say that it should not be on the buildbot, but I think there are significant blocking issues to putting it on the buildbot which should be resolved elsewhere.

orbea commented 6 years ago

@ofry Could you make an issue at the mpv-libretro repo asking how mpv-libretro could be incorporated into the buildbot if possible?

Specific points to cover are:

Making the issue here is not going to accomplish anything because the people who might be able to do something about this likely will never see it.

andres-asm commented 5 years ago

I added a few notes on the other issue

andres-asm commented 5 years ago

Basically, having it as a "standalone core" would be complex. But having it as a builtin core like the ffmpeg core would be trivial.

So I started with this https://hastebin.com/upetahoyir.pl

ofry commented 5 years ago

This PR could add audio callback:

https://github.com/mpv-player/mpv/pull/5566

Could anyone fix code style issues in this PR?